public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	linux-kernel@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Myungjoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH v2] cpufreq: stats: Add 'load_table' debugfs file to show accumulated data of CPUs
Date: Mon, 24 Jun 2013 20:18:50 +0900	[thread overview]
Message-ID: <51C82B1A.30906@samsung.com> (raw)
In-Reply-To: <4710866.fhlicB7Bsa@vostro.rjw.lan>

On 06/24/2013 08:00 PM, Rafael J. Wysocki wrote:
> On Monday, June 24, 2013 04:03:15 PM Viresh Kumar wrote:
>> On 24 June 2013 15:50, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>>> My impression was that that new interface wouldn't be useful on all platforms
>>> supported by cpufreq.  If that's the case, I'd rather not make changes in the
>>> core code that are needed only to implement that new interface, at least to
>>> start with.
>>
>> Every platform might not have userspace software that would do some
>> actions based on this. But, these are nice and useful stats to have.
>>
>> They tell you a lot about how the hardware/governor/policies are
>> behaving with load. And so will eventually help getting performance based
>> on governor tunables for your platform. That's why I asked to put this in
>> core as this should be pretty much useful.
> 
> OK, let's see how the code will look like.
> 
> Chanwoo, please prepare a v4 with the changes suggested by Viresh.
> 

@Viresh,
I implement v3 patch for load_table debugfs file. As you suggested, v3 pach include
old/new frequency data. But, I don't add additional function to minimize dependency
among cpufreq core functions. And then I use CPUFREQ_LOADCHECK and CPUFREQ_POSTCHANGE
notification to collect cpu data(time, old/new frequency, CPUs load).

Please review v3 patch for load_table debugfs file. Thanks.

Best Regards,
Chanwoo Choi


  reply	other threads:[~2013-06-24 11:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20  8:22 [PATCH v2] cpufreq: stats: Add 'load_table' debugfs file to show accumulated data of CPUs Chanwoo Choi
2013-06-20  9:03 ` Viresh Kumar
2013-06-20 10:45   ` Chanwoo Choi
2013-06-20 10:55     ` Viresh Kumar
2013-06-20 10:59       ` Chanwoo Choi
2013-06-20 11:18         ` Chanwoo Choi
2013-06-20 15:42           ` Viresh Kumar
2013-06-21  4:01             ` Chanwoo Choi
2013-06-21 13:13               ` Rafael J. Wysocki
2013-06-24  6:18                 ` Viresh Kumar
2013-06-24  9:39                   ` Rafael J. Wysocki
2013-06-24  9:41                     ` Viresh Kumar
2013-06-24 10:20                       ` Rafael J. Wysocki
2013-06-24 10:33                         ` Viresh Kumar
2013-06-24 11:00                           ` Rafael J. Wysocki
2013-06-24 11:18                             ` Chanwoo Choi [this message]
2013-06-24  8:32                 ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C82B1A.30906@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=rjw@sisk.pl \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox