From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] clk: Handle CLK_GET_RATE_NOCACHE flag in clk_set_rate()
Date: Mon, 24 Jun 2013 20:42:33 +0200 [thread overview]
Message-ID: <51C89319.3080409@samsung.com> (raw)
In-Reply-To: <20130621161627.9136.84494@quantum>
On 06/21/2013 06:16 PM, Mike Turquette wrote:
> Quoting Sylwester Nawrocki (2013-06-21 06:07:35)
>> > If a clock has CLK_GET_RATE_NOCACHE flag set the rate needs to
>> > be recalculated, rather than referencing the cached value.
>> >
>> > Currently cached clk->rate is compared with new value to see if
>> > anything needs to be done in clk_set_rate(). This may cause required
>> > clock controller registers update to not happen when same clock
>> > frequency value is being set subsequently.
>> >
>> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Peter already sent a patch for this:
> https://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=commitdiff;h=34e452a152efd25d654b7bc809df429337115b03
Thanks Mike, that also helps. My apologies for not having
it noticed earlier. I'm going to post a patch for the Exynos
clock driver, which adds missing CLK_GET_RATE_NOCACHE flags to
the ISP clock group and would be really effective together
with the above one.
Thanks,
Sylwester
prev parent reply other threads:[~2013-06-24 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 13:07 [PATCH] clk: Handle CLK_GET_RATE_NOCACHE flag in clk_set_rate() Sylwester Nawrocki
[not found] ` <20130621161627.9136.84494@quantum>
2013-06-24 18:42 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C89319.3080409@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox