Re: [PATCH 1/2] tracing/kprobes: move free_trace_probe into unregister_trace_probe

Steven Rostedt
2013-06-25T13:34:59Z

On Tue, 2013-06-25 at 18:37 +0800, zhangwei(Jovi) wrote:
> On 2013/6/25 18:10, Masami Hiramatsu wrote:
> > (2013/06/25 17:15), zhangwei(Jovi) wrote:
> >> There have no good reason to call free_trace_probe
> >> every time when unregister_trace_probe return 0.
> >>
> >> Move free_trace_probe into unregister_trace_probe,
> >> make code simpler.
> >
> > Sorry, nack. For the symmetrical coding reason, I don't like
> > involving "free" and "alloc" into "unregister"/"register"
> > functions. I think those should be just another actions.
> >
> > Thank you,
>
> That's fine, I just saw there have a little inconsistent between
> trace_kprobe.c and trace_uprobe.c.
>

Is there a place that trace_kprobe.c frees the tp structure in
unregister?

-- Steve