From: David Ahern <dsahern@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 15/15] perf tools: fix ppid in thread__fork()
Date: Tue, 25 Jun 2013 10:00:33 -0600 [thread overview]
Message-ID: <51C9BEA1.5000205@gmail.com> (raw)
In-Reply-To: <1372079772-20803-16-git-send-email-adrian.hunter@intel.com>
On 6/24/13 7:16 AM, Adrian Hunter wrote:
> ppid should be assigned to the parents pid. Note
> 'thread__fork()'s only caller 'machine__process_fork_event()'
> ensures that the parents pid is set.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/util/thread.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
> index e3d4a55..93f3eab 100644
> --- a/tools/perf/util/thread.c
> +++ b/tools/perf/util/thread.c
> @@ -85,7 +85,7 @@ int thread__fork(struct thread *self, struct thread *parent)
> if (map_groups__clone(&self->mg, &parent->mg, i) < 0)
> return -ENOMEM;
>
> - self->ppid = parent->tid;
> + self->ppid = parent->pid_;
Confused. My patch uses parent->pid and that it what I see in acme's
perf/core branch. When did this become parent->tid?
David
next prev parent reply other threads:[~2013-06-25 16:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 13:15 [PATCH 00/15] perf tools: some fixes and tweaks Adrian Hunter
2013-06-24 13:15 ` [PATCH 01/15] perf tools: remove unused parameter Adrian Hunter
2013-06-25 13:58 ` Jiri Olsa
2013-06-24 13:15 ` [PATCH 02/15] perf tools: fix missing tool parameter Adrian Hunter
2013-06-25 13:04 ` Jiri Olsa
2013-06-27 7:58 ` Adrian Hunter
2013-06-24 13:16 ` [PATCH 03/15] perf tools: fix missing 'finished_round' Adrian Hunter
2013-06-25 13:58 ` Jiri Olsa
2013-06-24 13:16 ` [PATCH 04/15] perf tools: fix parse_events_terms() segfault on error path Adrian Hunter
2013-06-25 13:59 ` Jiri Olsa
2013-06-24 13:16 ` [PATCH 05/15] perf tools: fix new_term() missing free " Adrian Hunter
2013-06-25 13:59 ` Jiri Olsa
2013-06-24 13:16 ` [PATCH 06/15] perf tools: fix parse_events_terms() freeing local variable " Adrian Hunter
2013-06-25 13:13 ` Jiri Olsa
2013-06-27 7:59 ` Adrian Hunter
2013-06-24 13:16 ` [PATCH 07/15] perf tools: add const specifier to perf_pmu__find name parameter Adrian Hunter
2013-06-24 13:16 ` [PATCH 08/15] perf tools: tidy duplicated munmap code Adrian Hunter
2013-06-25 14:00 ` Jiri Olsa
2013-06-24 13:16 ` [PATCH 09/15] perf tools: validate perf event header size Adrian Hunter
2013-06-25 13:18 ` Jiri Olsa
2013-06-27 7:59 ` Adrian Hunter
2013-06-26 1:44 ` Namhyung Kim
2013-06-27 8:01 ` Adrian Hunter
2013-06-24 13:16 ` [PATCH 10/15] perf tools: add debug prints Adrian Hunter
2013-06-25 14:01 ` Jiri Olsa
2013-06-24 13:16 ` [PATCH 11/15] perf tools: fix symbol_conf.nr_events Adrian Hunter
2013-06-24 13:16 ` [PATCH 12/15] perf tools: allow non-matching sample types Adrian Hunter
2013-06-25 11:23 ` Stephane Eranian
2013-06-25 12:13 ` Adrian Hunter
2013-06-25 14:45 ` Jiri Olsa
2013-06-25 15:42 ` David Ahern
2013-06-25 16:04 ` Jiri Olsa
2013-06-25 12:32 ` Jiri Olsa
2013-06-27 7:57 ` Adrian Hunter
2013-06-25 15:56 ` David Ahern
2013-06-25 16:03 ` Stephane Eranian
2013-06-25 23:04 ` David Ahern
2013-06-25 23:27 ` David Ahern
2013-06-27 8:02 ` Adrian Hunter
2013-06-26 20:48 ` David Ahern
2013-06-26 20:54 ` Stephane Eranian
2013-06-26 21:00 ` David Ahern
2013-06-26 21:07 ` Stephane Eranian
2013-06-24 13:16 ` [PATCH 13/15] perf tools: struct thread has a tid not a pid Adrian Hunter
2013-06-24 13:16 ` [PATCH 14/15] perf tools: add pid to struct thread Adrian Hunter
2013-06-24 13:16 ` [PATCH 15/15] perf tools: fix ppid in thread__fork() Adrian Hunter
2013-06-25 16:00 ` David Ahern [this message]
2013-06-25 16:04 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C9BEA1.5000205@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).