From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, tglx@linutronix.de,
hpa@linux.intel.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/asm] x86, processor-flags: Fix the datatypes and add bit number defines
Date: Tue, 25 Jun 2013 16:13:16 -0700 [thread overview]
Message-ID: <51CA240C.4000407@zytor.com> (raw)
In-Reply-To: <20130625230727.GB4396@pd.tnic>
On 06/25/2013 04:07 PM, Borislav Petkov wrote:
>
> Btw, are you going to need those _BIT defines anywhere else?
>
> Because if no, you could simply do:
>
> #define X86_EFLAGS_CF _BITUL(0) /* Carry Flag */
>
> and so on, and drop the _BIT defines.
>
Yes. I didn't get around to doing this particular bit of the cleanup,
but we have several places where we currently index various bits by
open-coded numbers, especially in assembly code.
-hpa
prev parent reply other threads:[~2013-06-25 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 22:54 [tip:x86/asm] x86, processor-flags: Fix the datatypes and add bit number defines tip-bot for H. Peter Anvin
2013-06-25 23:07 ` Borislav Petkov
2013-06-25 23:13 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CA240C.4000407@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox