From: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
To: Tony Luck <tony.luck@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
ananth@in.ibm.com, mahesh@linux.vnet.ibm.com,
Anton Vorontsov <cbouatmailru@gmail.com>,
Colin Cross <ccross@android.com>
Subject: Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase
Date: Wed, 26 Jun 2013 15:53:35 +0530 [thread overview]
Message-ID: <51CAC127.8070106@linux.vnet.ibm.com> (raw)
In-Reply-To: <CA+8MBbJ5Fa_q0_iS34g+5A5ghm087feODsCgMUJZJAGWTo_ZPg@mail.gmail.com>
On Tuesday 25 June 2013 10:40 PM, Tony Luck wrote:
> On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook <keescook@chromium.org> wrote:
>> On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah
>> <aruna@linux.vnet.ibm.com> wrote:
>>> pstore_erase is used to erase the record from the persistent store.
>>> So if a driver has not defined pstore_erase callback return
> How do people manage devices like this? With no erase function
> they just keep getting more and more pstore entries. Eventually
> they fill up.
We dont keep old records in the device. We have logs only of the
recent / last crash. The device has a predefined space for each type
of messages. For example: Every time a crash occurs the data gets
overwritten in the device allocated to store crash log.
>
>>> Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
>> Acked-by: Kees Cook <keescook@chromium.org>
> Applied - thanks.
>
> -Tony
>
prev parent reply other threads:[~2013-06-26 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 9:03 [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase Aruna Balakrishnaiah
2013-06-25 16:41 ` Kees Cook
2013-06-25 17:10 ` Tony Luck
2013-06-26 10:23 ` Aruna Balakrishnaiah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CAC127.8070106@linux.vnet.ibm.com \
--to=aruna@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=cbouatmailru@gmail.com \
--cc=ccross@android.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=tony.luck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox