* [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase
@ 2013-06-25 9:03 Aruna Balakrishnaiah
2013-06-25 16:41 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Aruna Balakrishnaiah @ 2013-06-25 9:03 UTC (permalink / raw)
To: tony.luck, linux-kernel
Cc: jkenisto, ananth, mahesh, cbouatmailru, ccross, keescook
pstore_erase is used to erase the record from the persistent store.
So if a driver has not defined pstore_erase callback return
-EPERM instead of unlinking a file as deleting the file without
erasing its record in persistent store will give a wrong impression
to customers.
Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
---
Changes from v1:
Fix error return value
fs/pstore/inode.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
index e4bcb2c..bfd95bf 100644
--- a/fs/pstore/inode.c
+++ b/fs/pstore/inode.c
@@ -178,6 +178,8 @@ static int pstore_unlink(struct inode *dir, struct dentry *dentry)
if (p->psi->erase)
p->psi->erase(p->type, p->id, p->count,
dentry->d_inode->i_ctime, p->psi);
+ else
+ return -EPERM;
return simple_unlink(dir, dentry);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase
2013-06-25 9:03 [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase Aruna Balakrishnaiah
@ 2013-06-25 16:41 ` Kees Cook
2013-06-25 17:10 ` Tony Luck
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2013-06-25 16:41 UTC (permalink / raw)
To: Aruna Balakrishnaiah
Cc: Tony Luck, LKML, jkenisto, ananth, mahesh, Anton Vorontsov,
Colin Cross
On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah
<aruna@linux.vnet.ibm.com> wrote:
> pstore_erase is used to erase the record from the persistent store.
> So if a driver has not defined pstore_erase callback return
> -EPERM instead of unlinking a file as deleting the file without
> erasing its record in persistent store will give a wrong impression
> to customers.
>
> Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
Acked-by: Kees Cook <keescook@chromium.org>
Thanks!
-Kees
--
Kees Cook
Chrome OS Security
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase
2013-06-25 16:41 ` Kees Cook
@ 2013-06-25 17:10 ` Tony Luck
2013-06-26 10:23 ` Aruna Balakrishnaiah
0 siblings, 1 reply; 4+ messages in thread
From: Tony Luck @ 2013-06-25 17:10 UTC (permalink / raw)
To: Kees Cook
Cc: Aruna Balakrishnaiah, LKML, Jim Keniston, ananth, mahesh,
Anton Vorontsov, Colin Cross
On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook <keescook@chromium.org> wrote:
> On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah
> <aruna@linux.vnet.ibm.com> wrote:
>> pstore_erase is used to erase the record from the persistent store.
>> So if a driver has not defined pstore_erase callback return
How do people manage devices like this? With no erase function
they just keep getting more and more pstore entries. Eventually
they fill up.
>> Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
>
> Acked-by: Kees Cook <keescook@chromium.org>
Applied - thanks.
-Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase
2013-06-25 17:10 ` Tony Luck
@ 2013-06-26 10:23 ` Aruna Balakrishnaiah
0 siblings, 0 replies; 4+ messages in thread
From: Aruna Balakrishnaiah @ 2013-06-26 10:23 UTC (permalink / raw)
To: Tony Luck
Cc: Kees Cook, LKML, Jim Keniston, ananth, mahesh, Anton Vorontsov,
Colin Cross
On Tuesday 25 June 2013 10:40 PM, Tony Luck wrote:
> On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook <keescook@chromium.org> wrote:
>> On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah
>> <aruna@linux.vnet.ibm.com> wrote:
>>> pstore_erase is used to erase the record from the persistent store.
>>> So if a driver has not defined pstore_erase callback return
> How do people manage devices like this? With no erase function
> they just keep getting more and more pstore entries. Eventually
> they fill up.
We dont keep old records in the device. We have logs only of the
recent / last crash. The device has a predefined space for each type
of messages. For example: Every time a crash occurs the data gets
overwritten in the device allocated to store crash log.
>
>>> Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
>> Acked-by: Kees Cook <keescook@chromium.org>
> Applied - thanks.
>
> -Tony
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-26 10:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-25 9:03 [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase Aruna Balakrishnaiah
2013-06-25 16:41 ` Kees Cook
2013-06-25 17:10 ` Tony Luck
2013-06-26 10:23 ` Aruna Balakrishnaiah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox