Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

[Jason Baron <jbaron@akamai.com>]

On 06/25/2013 02:03 PM, Joe Perches wrote:
> (Using Jason Baron's most current email address)
>
> On Tue, 2013-06-25 at 10:56 -0700, Joe Perches wrote:
>> On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote:
>>> On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote:
>>>> a long needed extension to dev_dbg is to enable classes
>>>> of messages by level or mask.
>>>>
>>>> There are many existing macros like
>>>>
>>>> #define module_dbg(level, fmt, ...)
>>>> do {
>>>> 	if (level >= some_module_var)
>>>> 		debug_something(...);
>>>> } while (0)
>>>>
>>>> and
>>>>
>>>> #define module_dbg(mask, fmt, ...)
>>>> do {
>>>> 	if (mask & some_module_var)
>>>> 		debug_something(...)
>>>> } while (0)
>>>>
>>>> It'd be nice to consolidate those in dev_dbg
>>> I'd almost recommend that all of them just be removed, because most of
>>> them were only used for debugging the code the first time it was
>>> developed, right?  Only for very limited usages would this type of thing
>>> be needed.
>> Maybe, though that's hard to know with certainty.
>> How often module options are used isn't easy to find out.
>>
>> These forms are sometimes used to reduce object size.
> Hey Jason.  Your redhat.com address is out of date.
>
> If you're still interested in dynamic_debug, you should
> update your MAINTAINERS entry.
>
>

Hi Joe,

Thanks for asking - I'll send out a patch to update it.

Thanks,

-Jason