From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947Ab3F0CGe (ORCPT ); Wed, 26 Jun 2013 22:06:34 -0400 Received: from intranet.asianux.com ([58.214.24.6]:11283 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643Ab3F0CGd (ORCPT ); Wed, 26 Jun 2013 22:06:33 -0400 X-Spam-Score: -100.8 Message-ID: <51CB9DD8.6040905@asianux.com> Date: Thu, 27 Jun 2013 10:05:12 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Catalin Marinas CC: Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann Subject: Re: [PATCH] arch: arm64: include: asm: add pci.h to pass compiling References: <51CA5F71.207@asianux.com> <20130626140730.GB23309@arm.com> <51CB87B0.8030805@asianux.com> In-Reply-To: <51CB87B0.8030805@asianux.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/27/2013 08:30 AM, Chen Gang wrote: > On 06/26/2013 10:07 PM, Catalin Marinas wrote: >> On Wed, Jun 26, 2013 at 04:26:41AM +0100, Chen Gang wrote: >>>> Need add pci.h for compiling, the related error (with allmodconfig): >>>> >>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ¡®flexcop_usb_transfer_exit¡¯: >>>> drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ¡®pci_free_consistent¡¯ [-Werror=implicit-function-declaration] >>>> drivers/media/usb/b2c2/flexcop-usb.c: In function ¡®flexcop_usb_transfer_init¡¯: >>>> drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ¡®pci_alloc_consistent¡¯ [-Werror=implicit-function-declaration] >>>> drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default] >>>> cc1: some warnings being treated as errors >>>> >>>> Signed-off-by: Chen Gang >>>> --- >>>> arch/arm64/include/asm/pci.h | 11 +++++++++++ >>>> 1 files changed, 11 insertions(+), 0 deletions(-) >>>> create mode 100644 arch/arm64/include/asm/pci.h >>>> >>>> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h >>>> new file mode 100644 >>>> index 0000000..2ed467f >>>> --- /dev/null >>>> +++ b/arch/arm64/include/asm/pci.h >>>> @@ -0,0 +1,11 @@ >>>> +#ifndef ASMARM64_PCI_H >>>> +#define ASMARM64_PCI_H >>>> + >>>> +#ifdef __KERNEL__ >>>> + >>>> +#include >>>> +#include >>>> + >>>> +#endif /* __KERNEL__ */ >>>> + >>>> +#endif >> I wonder whether it makes sense to include pci-dma-compat.h in >> asm-generic/pci.h, I don't see why one would want the generic pci.h but >> not the generic pci-dma-compat.h (cc'ing Arnd). > For m32r, it needs generic pci.h but not the generic pci-dma-compat.h. I am just compiling it with allmodconfig to see whether it will can cause issue too, if so I will send the patch for asm-generic. :-) And, sorry for the original reply below is incorrect. > I think, it will let architecture guys easier to add their own > pci-dma-compat.h (although they still need generic pci_dma_compat.h, and > generic pci.h, too). > > e.g. one architecture want include generic pci-dma-compat.h firstly, > then define its own features in its own pci-dma-compat.h. > > Thanks. > -- Chen Gang