From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752313Ab3F0Jdr (ORCPT ); Thu, 27 Jun 2013 05:33:47 -0400 Received: from intranet.asianux.com ([58.214.24.6]:59682 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739Ab3F0Jdq (ORCPT ); Thu, 27 Jun 2013 05:33:46 -0400 X-Spam-Score: -100.9 Message-ID: <51CC06C5.2040702@asianux.com> Date: Thu, 27 Jun 2013 17:32:53 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Arnd Bergmann , Hirokazu Takata , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, "linux-kernel@vger.kernel.org" , Linux-Arch Subject: Re: [PATCH] arch: m32r: include: asm: add ioread*_rep() and iowrite*_rep() References: <51CBA43F.9050000@asianux.com> <51CBAA1E.8000206@asianux.com> <51CBB1A9.5080203@asianux.com> <51CBC186.3080401@asianux.com> <51CBFDED.9090203@asianux.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/27/2013 05:28 PM, Geert Uytterhoeven wrote: > On Thu, Jun 27, 2013 at 10:55 AM, Chen Gang wrote: >> > On 06/27/2013 03:07 PM, Geert Uytterhoeven wrote: >>> >> On Thu, Jun 27, 2013 at 6:37 AM, Chen Gang wrote: >>>> >>> --- a/arch/m32r/include/asm/io.h >>>> >>> +++ b/arch/m32r/include/asm/io.h >>>> >>> @@ -169,6 +169,20 @@ static inline void _writel(unsigned long l, unsigned long addr) >>>> >>> #define iowrite16 writew >>>> >>> #define iowrite32 writel >>>> >>> >>>> >>> +#define ioread8_rep(p, dst, count) \ >>>> >>> + insb((unsigned long) (p), (dst), (count)) >>> >> >>> >> As ioread8() is mapped to readb() (I/O memory space), not inb() (I/O >>> >> port space), >>> >> ioread8_rep() should map to readsb() (which m32r doesn't have yet >>> >> BTW), not insb(). >>> >> For m32r this does matter, as inb() and readb() use different mechanisms >>> >> internally. >>> >> >> > >> > Reasonable, but excuse me, I am not quite familiar with it, can any >> > other members (or maintainer) to help implement it ? >> > >> > Thanks firstly. >> > >> > :-) >> > >>> >> It seems include/asm-generic/io.h also has this wrong? >>> >> >> > >> > I think it need improvement, if readsb has been defined, it should use >> > readsb() instead, or just use insb(). > I think m32r can mostly use asm-generic/io.h. > I.e. arch/m32r/include/asm/io.h has to #define all the operations it implements > itself, and defer the rest to asm-generic/io.h. Really it is, if Arnd's patch for asm-generic/io.h pass checking and is applied, thanks. Hello Arnd: Can you help to send the related patch too, since you have already send the patch for asm-generic/io.h, which this patch depends on. Thanks. -- Chen Gang