* [PATCH] arch: m32r: include: asm: add "dma-mapping-common.h"
@ 2013-06-27 4:50 Chen Gang
2013-06-27 8:30 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Chen Gang @ 2013-06-27 4:50 UTC (permalink / raw)
To: Hirokazu Takata
Cc: dhowells@redhat.com, Arnd Bergmann, Paul McKenney,
sfr@canb.auug.org.au, Rusty Russell, linux-m32r, linux-m32r-ja,
linux-kernel@vger.kernel.org, Linux-Arch
Need add generic "dma-mapping-common.h", or compiling may fail.
The related error (with allmodconfig):
CC [M] net/irda/irlan/irlan_eth.o
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implicit declaration of function ‘dma_mmap_coherent’ [-Werror=implicit-function-declaration]
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implicit declaration of function ‘dma_get_sgtable’ [-Werror=implicit-function-declaration]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/m32r/include/asm/Kbuild | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/m32r/include/asm/Kbuild b/arch/m32r/include/asm/Kbuild
index bebdc36..fecca22 100644
--- a/arch/m32r/include/asm/Kbuild
+++ b/arch/m32r/include/asm/Kbuild
@@ -1,5 +1,6 @@
generic-y += clkdev.h
+generic-y += dma-mapping-common.h
generic-y += exec.h
generic-y += module.h
generic-y += trace_clock.h
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arch: m32r: include: asm: add "dma-mapping-common.h"
2013-06-27 4:50 [PATCH] arch: m32r: include: asm: add "dma-mapping-common.h" Chen Gang
@ 2013-06-27 8:30 ` Arnd Bergmann
2013-06-27 9:27 ` Chen Gang
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2013-06-27 8:30 UTC (permalink / raw)
To: Chen Gang
Cc: Hirokazu Takata, dhowells@redhat.com, Paul McKenney,
sfr@canb.auug.org.au, Rusty Russell, linux-m32r, linux-m32r-ja,
linux-kernel@vger.kernel.org, Linux-Arch
On Thursday 27 June 2013 12:50:59 Chen Gang wrote:
> Need add generic "dma-mapping-common.h", or compiling may fail.
>
> The related error (with allmodconfig):
>
> CC [M] net/irda/irlan/irlan_eth.o
> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
> drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implicit declaration of function ‘dma_mmap_coherent’ [-Werror=implicit-function-declaration]
> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
> drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implicit declaration of function ‘dma_get_sgtable’ [-Werror=implicit-function-declaration]
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
m32r does not provide the "common" version of the dma mapping API, so this
is certainly wrong.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arch: m32r: include: asm: add "dma-mapping-common.h"
2013-06-27 8:30 ` Arnd Bergmann
@ 2013-06-27 9:27 ` Chen Gang
2013-06-27 9:40 ` Chen Gang
0 siblings, 1 reply; 4+ messages in thread
From: Chen Gang @ 2013-06-27 9:27 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Hirokazu Takata, dhowells@redhat.com, Paul McKenney,
sfr@canb.auug.org.au, Rusty Russell, linux-m32r, linux-m32r-ja,
linux-kernel@vger.kernel.org, Linux-Arch
On 06/27/2013 04:30 PM, Arnd Bergmann wrote:
> On Thursday 27 June 2013 12:50:59 Chen Gang wrote:
>> Need add generic "dma-mapping-common.h", or compiling may fail.
>>
>> The related error (with allmodconfig):
>>
>> CC [M] net/irda/irlan/irlan_eth.o
>> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
>> drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implicit declaration of function ‘dma_mmap_coherent’ [-Werror=implicit-function-declaration]
>> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
>> drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implicit declaration of function ‘dma_get_sgtable’ [-Werror=implicit-function-declaration]
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>
> m32r does not provide the "common" version of the dma mapping API, so this
> is certainly wrong.
>
But m32r really has pci.h, and also can cause this issue.
Thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arch: m32r: include: asm: add "dma-mapping-common.h"
2013-06-27 9:27 ` Chen Gang
@ 2013-06-27 9:40 ` Chen Gang
0 siblings, 0 replies; 4+ messages in thread
From: Chen Gang @ 2013-06-27 9:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Hirokazu Takata, dhowells@redhat.com, Paul McKenney,
sfr@canb.auug.org.au, Rusty Russell, linux-m32r, linux-m32r-ja,
linux-kernel@vger.kernel.org, Linux-Arch
On 06/27/2013 05:27 PM, Chen Gang wrote:
> On 06/27/2013 04:30 PM, Arnd Bergmann wrote:
>> > On Thursday 27 June 2013 12:50:59 Chen Gang wrote:
>>> >> Need add generic "dma-mapping-common.h", or compiling may fail.
>>> >>
>>> >> The related error (with allmodconfig):
>>> >>
>>> >> CC [M] net/irda/irlan/irlan_eth.o
>>> >> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
>>> >> drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implicit declaration of function ‘dma_mmap_coherent’ [-Werror=implicit-function-declaration]
>>> >> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
>>> >> drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implicit declaration of function ‘dma_get_sgtable’ [-Werror=implicit-function-declaration]
>>> >>
>>> >>
>>> >> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> >
>> > m32r does not provide the "common" version of the dma mapping API, so this
>> > is certainly wrong.
>> >
Oh, sorry, the reply below is incorrect, I will check it, again, thanks.
> But m32r really has pci.h, and also can cause this issue.
--
Chen Gang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-27 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-27 4:50 [PATCH] arch: m32r: include: asm: add "dma-mapping-common.h" Chen Gang
2013-06-27 8:30 ` Arnd Bergmann
2013-06-27 9:27 ` Chen Gang
2013-06-27 9:40 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox