From: John Stultz <john.stultz@linaro.org>
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xen.org,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/5] time: indicate that the clock was set in the pvclock gtod notifier chain
Date: Thu, 27 Jun 2013 10:37:20 -0700 [thread overview]
Message-ID: <51CC7850.2040602@linaro.org> (raw)
In-Reply-To: <1372329348-20841-4-git-send-email-david.vrabel@citrix.com>
On 06/27/2013 03:35 AM, David Vrabel wrote:
> From: David Vrabel <david.vrabel@citrix.com>
>
> If the clock was set (stepped), set the action parameter to functions
> in the pvclock gtod notifier chain to non-zero. This allows the
> callee to only do work if the clock was stepped.
>
> This will be used on Xen as the synchronization of the Xen wallclock
> to the control domain's (dom0) system time will be done with this
> notifier and updating on every timer tick is unnecessary and too
> expensive.
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Looks pretty good. Minor note below.
>
> @@ -1239,9 +1240,10 @@ out_adjust:
> * It also calls into the NTP code to handle leapsecond processing.
> *
> */
> -static inline void accumulate_nsecs_to_secs(struct timekeeper *tk)
> +static inline bool accumulate_nsecs_to_secs(struct timekeeper *tk)
Shouldn't this be unsigned instead of bool?
thanks
-john
next prev parent reply other threads:[~2013-06-27 17:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 10:35 [PATCHv6 0/5] xen: maintain an accurate persistent clock in more cases David Vrabel
2013-06-27 10:35 ` [PATCH 1/5] hrtimers: support resuming with two or more CPUs online (but stopped) David Vrabel
2013-06-28 21:18 ` [tip:timers/core] hrtimers: Support " tip-bot for David Vrabel
2013-07-05 9:30 ` Artem Savkov
2013-07-05 10:07 ` David Vrabel
2013-07-05 10:10 ` Thomas Gleixner
2013-07-05 10:25 ` Thomas Gleixner
2013-07-05 10:36 ` Thomas Gleixner
2013-07-05 10:45 ` Artem Savkov
2013-07-05 13:26 ` Thomas Gleixner
2013-07-05 10:38 ` Artem Savkov
2013-07-05 13:46 ` David Vrabel
2013-07-05 13:51 ` Thomas Gleixner
2013-07-05 10:09 ` Thomas Gleixner
2013-06-28 21:18 ` [tip:timers/core] xen: Remove clock_was_set() call in the resume path tip-bot for David Vrabel
2013-06-27 10:35 ` [PATCH 2/5] time: pass flags instead of multiple bools to timekeeping_update() David Vrabel
2013-06-27 17:39 ` John Stultz
2013-06-28 21:18 ` [tip:timers/core] timekeeping: Pass " tip-bot for David Vrabel
2013-06-27 10:35 ` [PATCH 3/5] time: indicate that the clock was set in the pvclock gtod notifier chain David Vrabel
2013-06-27 17:37 ` John Stultz [this message]
2013-06-28 10:20 ` David Vrabel
2013-06-28 21:19 ` [tip:timers/core] timekeeping: Indicate that clock was set in the pvclock gtod notifier tip-bot for David Vrabel
2013-06-27 10:35 ` [PATCH 4/5] x86/xen: sync the wallclock when the system time is set David Vrabel
2013-06-28 21:19 ` [tip:timers/core] x86: xen: Sync " tip-bot for David Vrabel
2013-06-27 10:35 ` [PATCH 5/5] x86/xen: sync the CMOS RTC as well as the Xen wallclock David Vrabel
2013-06-28 15:38 ` Thomas Gleixner
2013-06-28 15:49 ` David Vrabel
2013-06-28 16:09 ` Thomas Gleixner
2013-06-28 16:51 ` David Vrabel
2013-06-28 20:41 ` Thomas Gleixner
2013-06-28 21:19 ` [tip:timers/core] x86: xen: Sync " tip-bot for David Vrabel
2013-06-28 13:14 ` [PATCHv6 0/5] xen: maintain an accurate persistent clock in more cases Thomas Gleixner
2013-06-28 15:01 ` Konrad Rzeszutek Wilk
2013-06-28 15:12 ` Thomas Gleixner
2013-06-28 16:19 ` Konrad Rzeszutek Wilk
2013-06-28 18:58 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC7850.2040602@linaro.org \
--to=john.stultz@linaro.org \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).