From: "Li, Zhen-Hua (USL-China)" <zhen-hual@hp.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices
Date: Fri, 28 Jun 2013 09:05:03 +0800 [thread overview]
Message-ID: <51CCE13F.6070009@hp.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1306271150330.1167-100000@iolanthe.rowland.org>
There was a problem, the warning "Controller not stopped yet".
And your last patch for this problem does a wrong thing:
It prevents all HP uhci devices from auto-stop, which make HP uhci
devices waste more
power.
This is another new problem.
I think this should be corrected, so I want to apply it.
Thanks
Zhen-Hua
On 06/27/2013 11:52 PM, Alan Stern wrote:
> On Thu, 27 Jun 2013, Li, Zhen-Hua (USL-China) wrote:
>
>> Hi Alan,
>>
>> I don't have a machine that this makes action different.
> Then why do you want to apply the patch?
>
>> No matter whether it makes different, there is one thing will never change:
>> We create a patch to FIX a problem, not to avoid a problem.
>> Only when we can not fix it, we try to avoid it.
> But in this case, there is no problem to fix or to avoid, right? After
> all, how can there be a problem if no machines are affected?
>
> Alan Stern
>
> .
>
next prev parent reply other threads:[~2013-06-28 1:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 6:29 [PATCH 1/1] usb,uhci: add a new tag for virtual uhci devices Li, Zhen-Hua
2013-06-26 19:17 ` Alan Stern
2013-06-27 1:17 ` Li, Zhen-Hua (USL-China)
2013-06-27 15:52 ` Alan Stern
2013-06-28 1:05 ` Li, Zhen-Hua (USL-China) [this message]
2013-06-28 14:22 ` Alan Stern
2013-07-01 1:11 ` ZhenHua
2013-07-01 14:29 ` Alan Stern
2013-07-24 22:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CCE13F.6070009@hp.com \
--to=zhen-hual@hp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox