Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.

Chen Gang
2013-07-01T02:40:18Z

On 06/29/2013 04:26 PM, Geert Uytterhoeven wrote:
> On Sat, Jun 29, 2013 at 10:01 AM, Michael Schmitz <schmitzmic@gmail.com> wrote:
>>> >> The same .config file, also report the compiling error below:
>>> >>
>>> >> drivers/i2c/busses/i2c-ocores.c:81:2: error: implicit declaration of
>>> >> function ‘iowrite8’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:86:2: error: implicit declaration of
>>> >> function ‘iowrite16’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:91:2: error: implicit declaration of
>>> >> function ‘iowrite32’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:96:2: error: implicit declaration of
>>> >> function ‘ioread8’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:101:2: error: implicit declaration of
>>> >> function ‘ioread16’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:106:2: error: implicit declaration of
>>> >> function ‘ioread32’ [-Werror=implicit-function-declaration]
>>> >>
>>> >> Excuse me, I am not quite familiar with the related hardware and m68k,
>>> >> I guess under m68k architecture, we need not this drivers, is it correct ?
> Until someone synthesizes the OpenCores i2c core together with the
> OpenCores 68000 core (they seem to have one), and tries to run uClinux
> on it...
>

OK, thanks.

>> > That would be correct, yes. Perhaps add appropriate dependencies in
>> > drivers/i2c/Kconfig to allow building I2C drivers
>> > only on hardware that supports it?
> We still want it for compile-coverage.
>
> Now, the issue is that m68knommu doesn't implement ioread8() and
> friends, so I'm adding the uClinux list.

Do you also add it to main tree (e.g next-tree), if not, I recommend to
do add it to main tree.

Thanks.
--
Chen Gang