From: Roger Quadros <rogerq@ti.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: <balbi@ti.com>, <tony@atomide.com>, <ruslan.bilovol@ti.com>,
<linux-usb@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend
Date: Mon, 1 Jul 2013 11:33:52 +0300 [thread overview]
Message-ID: <51D13EF0.6030702@ti.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1306281507020.1047-100000@iolanthe.rowland.org>
On 06/28/2013 10:18 PM, Alan Stern wrote:
> On Fri, 28 Jun 2013, Roger Quadros wrote:
>
>> Just found the problem. It seems that enabling the ehci_irq _after_ the root hub is resumed
>> is the root cause of the problem. Doing so will miss events from the root hub.
>
> This sounds like a bug in the IRQ setup. It's the sort of thing you
> see when a level-triggered IRQ is treated as though it were
> edge-triggered.
>
> In any case, the wakeup should have worked whether the IRQ was issued
> or not.
>
OK.
>
> I appreciate the symmetry of putting the enable_irq call in ehci-hcd,
> seeing as how the disable_irq is there too. On the other hand, every
> HCD using this mechanism is going to have to do the same thing, which
> argues for putting the enable call in the core. Perhaps at the start
OK.
> of hcd_resume_work() instead of the end.
>
We can't enable_irq at the start as the controller will only be resumed
after usb_remote_wakeup().
cheers,
-roger
next prev parent reply other threads:[~2013-07-01 8:34 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 14:05 [RFC PATCH 0/6] Suspend USB Host controller on bus suspend Roger Quadros
2013-06-19 14:05 ` [RFC PATCH 1/6] mfd: omap-usb-host: move initialization to module_init() Roger Quadros
2013-06-20 12:07 ` Felipe Balbi
2013-06-20 12:29 ` Roger Quadros
2013-06-19 14:05 ` [RFC PATCH 2/6] mfd: omap-usb-host: Put pins in IDLE state on suspend Roger Quadros
2013-06-19 17:23 ` Kevin Hilman
2013-06-20 7:21 ` Tony Lindgren
2013-06-20 12:30 ` Roger Quadros
2013-06-19 14:05 ` [RFC PATCH 3/6] USB: ehci: allow controller drivers to override irq & bus_suspend/resume Roger Quadros
2013-06-19 14:05 ` [RFC PATCH 4/6] USB: ehci-omap: Suspend the controller during bus suspend Roger Quadros
2013-06-19 17:39 ` Kevin Hilman
2013-06-20 12:32 ` Roger Quadros
2013-06-20 12:11 ` Felipe Balbi
2013-06-20 12:35 ` Roger Quadros
2013-06-20 17:33 ` Alan Stern
2013-06-24 15:09 ` Roger Quadros
2013-06-24 19:34 ` Alan Stern
2013-06-25 13:59 ` Roger Quadros
2013-06-25 17:38 ` Alan Stern
2013-06-26 13:38 ` Roger Quadros
2013-06-27 15:40 ` Alan Stern
2013-06-28 12:20 ` Roger Quadros
2013-06-28 13:57 ` Roger Quadros
2013-06-28 19:18 ` Alan Stern
2013-07-01 8:33 ` Roger Quadros [this message]
2013-06-28 19:06 ` Alan Stern
2013-07-01 8:16 ` Roger Quadros
2013-07-01 16:24 ` Alan Stern
2013-07-01 16:49 ` Felipe Balbi
2013-07-01 21:01 ` Alan Stern
2013-07-02 8:22 ` Roger Quadros
2013-07-02 17:17 ` Alan Stern
2013-07-03 9:13 ` Roger Quadros
2013-07-03 12:57 ` Felipe Balbi
2013-07-03 13:06 ` Roger Quadros
2013-07-03 13:15 ` Felipe Balbi
2013-07-03 14:30 ` Alan Stern
2013-07-09 13:58 ` Roger Quadros
2013-06-19 14:05 ` [RFC PATCH 5/6] ARM: dts: omap3beagle-xm: Add idle state pins for USB host Roger Quadros
2013-06-19 18:42 ` Kevin Hilman
2013-06-20 11:55 ` Roger Quadros
2013-06-20 12:02 ` Roger Quadros
2013-06-20 13:02 ` Roger Quadros
2013-06-19 14:05 ` [RFC PATCH 6/6] ARM: OMAP3: Enable Hardware Save and Restore for USB Host Roger Quadros
2013-06-19 17:30 ` Sergei Shtylyov
2013-06-20 12:42 ` Roger Quadros
2013-06-19 15:23 ` [RFC PATCH 0/6] Suspend USB Host controller on bus suspend Alan Stern
2013-06-20 12:39 ` Roger Quadros
2013-06-20 17:19 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D13EF0.6030702@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ruslan.bilovol@ti.com \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox