From: Stephen Warren <swarren@wwwdotorg.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Russell King <linux@arm.linux.org.uk>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Joseph Lo <josephl@nvidia.com>,
linux-tegra@vger.kernel.org, Stephen Warren <swarren@nvidia.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: move body of head-common.S back to text section
Date: Tue, 02 Jul 2013 20:44:20 -0600 [thread overview]
Message-ID: <51D39004.9000907@wwwdotorg.org> (raw)
In-Reply-To: <20130702232259.GH11625@codeaurora.org>
On 07/02/2013 05:22 PM, Stephen Boyd wrote:
> On 07/02, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Commit 281ecb7 "arm: delete __cpuinit/__CPUINIT usage from all ARM
>> users" removed a __CPUINIT from head-common.S. However, the code
>> immediately before the removed tag was marked __INIT, and was missing
>> a match __FINIT. This caused code after the removed __CPUINIT to end
>> up in the init section rather than the main text section as desired.
>> This caused issues such as secondary CPU boot failures or crashes.
>> Add the missing __FINIT to solve this.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>> arch/arm/kernel/head-common.S | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
>> index 529ce99..a9dc804 100644
>> --- a/arch/arm/kernel/head-common.S
>> +++ b/arch/arm/kernel/head-common.S
>> @@ -122,6 +122,8 @@ __mmap_switched_data:
>> .long init_thread_union + THREAD_START_SP @ sp
>> .size __mmap_switched_data, . - __mmap_switched_data
>>
>> + __FINIT
>> +
>> /*
>> * This provides a C-API version of __lookup_processor_type
>> */
>
> Shouldn't this come after lookup_processor_type()? Otherwise you
> just removed that function from the init section?
I think this is correct. Prior to "arm: delete __cpuinit/__CPUINIT usage
from all ARM users", lookup_processor_type() was in the cpuinit section.
After that commit, it moved to the init section and hence got dumped
soon after boot. The change above moves lookup_processor_type() back
into the regular text section, which I believe was the intent of the
__cpuinit removal patch.
next prev parent reply other threads:[~2013-07-03 2:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 22:53 [PATCH] ARM: move body of head-common.S back to text section Stephen Warren
2013-07-02 23:22 ` Stephen Boyd
2013-07-03 2:44 ` Stephen Warren [this message]
2013-07-03 5:19 ` Paul Gortmaker
2013-07-03 10:00 ` Russell King - ARM Linux
2013-07-03 15:30 ` Paul Gortmaker
2013-07-03 17:20 ` Russell King - ARM Linux
2013-07-04 0:22 ` Paul Gortmaker
2013-07-05 15:10 ` Dave P Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D39004.9000907@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul.gortmaker@windriver.com \
--cc=sboyd@codeaurora.org \
--cc=swarren@nvidia.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox