Re: [PATCH v5 0/6] Android Binder IPC Fixes

[Serban Constantinescu <Serban.Constantinescu@arm.com>]

On 03/07/13 23:32, Arve Hjønnevåg wrote:
> On Wed, Jul 3, 2013 at 9:35 AM, Serban Constantinescu
> <Serban.Constantinescu@arm.com> wrote:
>> Hi all,
>>
>> Any feedback or comments on this patch set?
>>
>> Thanks,
>> Serban
>>
>
> The new patches look OK, but I would like to also see the patches that
> add support for 32 bit user-space on a 64 bit kernel.

I have added the last change to v6 and kept Arve's ack.

I will rebase my binder kernel compat on this latest version and polish 
the patch set such that is ready for upstream. I should have something 
ready for your review soon.

Thanks for your help,
Serban Constantinescu

>
>>
>> On 19/06/13 18:12, Serban Constantinescu wrote:
>>>
>>> Hi all,
>>>
>>> This set of patches will clean-up and fix some of the issues that arise
>>> with the current binder interface when moving to a 64bit kernel. All these
>>> changes will not affect the existing 32bit Android interface and are meant
>>> to stand as the base for the 64bit binder compat layer(kernel or
>>> userpsace).
>>>
>>> The patch set has been successfully tested with a 64bit Linux userspace
>>> and
>>> 64bit binder unit-tests.
>>>
>>> This patch set has been successfully tested on 32bit platforms(ARMv7
>>> VExpress)
>>> and 64bit platforms(ARMv8 RTSM) running a 32bit Android userspace and an
>>> in
>>> kernel binder compat layer.
>>>
>>> Changes for v5:
>>> 1 6/6: Moved patch to the end of the series; changed handle to use __u32
>>> type
>>> 2 4/6: Removed some of the alignment/buffer changes introduced in previous
>>>          versions of the patch.
>>>
>>> Changes for v4:
>>> 1: 5/6: Fix the offset buffer alignment such that it will work for cases
>>> where
>>> buffer start + buffer size are not aligned to (void *)
>>>
>>> Changes for v3:
>>> 1:  Dropped the patch that was replacing uint32_t types with unsigned int
>>> 2:  Dropped the patch fixing the IOCTL types(since it has been added to
>>> Greg's
>>>       staging tree)
>>> 3:  Split one patch into two: 'modify binder_write_read' and '64bit
>>> changes'
>>> 4:  Modified BINDER_SET_MAX_THREADS ioctl definition accordint to Arve's
>>> review
>>> 5:  Modified the binder command IOCTL declarations according to Arve's
>>> review
>>>
>>> Changes for v2:
>>> 1: 1/7: Modified the commit message according to Greg's feedback;
>>> 2: 3/7: Merged with the patch fixing the printk format specifiers.
>>>
>>> Serban Constantinescu (6):
>>>     staging: android: binder: modify struct binder_write_read to use
>>>       size_t
>>>     staging: android: binder: fix BINDER_SET_MAX_THREADS declaration
>>>     staging: android: binder: fix BC_FREE_BUFFER ioctl declaration
>>>     staging: android: binder: fix alignment issues
>>>     staging: android: binder: replace types with portable ones
>>>     staging: android: binder: fix binder interface for 64bit compat layer
>>>
>>>    drivers/staging/android/binder.c |   32 ++++++++++++-------------
>>>    drivers/staging/android/binder.h |   48
>>> +++++++++++++++++++-------------------
>>>    2 files changed, 40 insertions(+), 40 deletions(-)
>>>
>>
>>
>> --
>> Best Regards,
>>
>> Serban Constantinescu
>> PDSW Engineer ARM Ltd.
>>
>
>
>
> --
> Arve Hjønnevåg
>