Re: [PATCH 2/2 v6] tracing/uprobes: Support soft-mode disabling

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2013/07/04 20:04), zhangwei(Jovi) wrote:
> Support soft-mode disabling on uprobe-based dynamic events.
> Soft-disabling is just ignoring recording if the soft disabled
> flag is set.
> 
> Signed-off-by: zhangwei(Jovi) <jovi.zhangwe@huawei.com>

looks good for me too.

Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks!

> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
>  kernel/trace/trace_uprobe.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 2fc9931..94f180d 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -530,6 +530,9 @@ static void uprobe_trace_print(struct trace_uprobe *tu,
> 
>  	WARN_ON(call != ftrace_file->event_call);
> 
> +	if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
> +		return;
> +
>  	size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
>  	event = trace_event_buffer_lock_reserve(&buffer, ftrace_file,
>  						call->event.type,
> 


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com