Re: [PATCH 3/5] drivers/misc: rf/ad9361: AD9361 device driver for Radio phy

[pankaj chauhan <pankaj.chauhan@freescale.com>]

On 7/4/2013 1:06 AM, Mark Brown wrote:
> On Thu, Jun 20, 2013 at 04:05:20PM +0530, pankaj chauhan wrote:
> 
>> Yes modifying registers from user space is part of the patch set and
>> register read/write interface is aimed only for two purposes:
>>
>> 1. Debugging : taking register dumps etc.
> 
> Use regmap, it should have the infrastructure you need here.
> 
Thanks! I looked into regmap, and it is exactly what we want. We'll
remove reg read/write from our patch and use regmap.
>> 2. Initializing AD9361 using Low level script generated by ADI GUI tool.
> 
> This sounds like generating a firmmware blob that the driver can load.
> You may have to cook the GUI output to be more amenable to loading in
> the kernel (or persuade the GUI guys to generate something useful here).
> 
Yes it is kind of generating firmware blob from GUI tool. They reason
why we choose to initialize AD9361 using script generated by GUI tool
was lack of our insight in AD9361, and script is the quickest way to
bring-up AD9361. This GUI is developed by analog devices, so we don't
have much control on it. Lars and Robin are developing full fledged
driver for Ad9661, We intend to use that driver only, that's why in next
version of patch we'll remove AD9361 driver from our patchset, and
integrate with Lars' driver once it is available.