From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757570Ab3GESnL (ORCPT ); Fri, 5 Jul 2013 14:43:11 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:49562 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162Ab3GESnJ (ORCPT ); Fri, 5 Jul 2013 14:43:09 -0400 Message-ID: <51D713B9.40205@wwwdotorg.org> Date: Fri, 05 Jul 2013 12:43:05 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Laxman Dewangan CC: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: tegra: enable gpio-keys on dalmore References: <1373028111-24246-1-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1373028111-24246-1-git-send-email-ldewangan@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/05/2013 06:41 AM, Laxman Dewangan wrote: > Dalmore have the keys mounted on board which are connected > to different pins of Tegra. > > Add the keys entry in DTS file to enable key functionality. > This will enable KEY_POWER, KEY_HOME, KEY_VOLUMEUP and > KEY_VOLUMEDOWN. > diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts > <&tegra_car TEGRA114_CLK_EXTERN1>; > clock-names = "pll_a", "pll_a_out0", "mclk"; > }; > + > + gpio-keys { The node above is "sound". This node should be before that node so they're alphabetically sorted. > + compatible = "gpio-keys"; > + > + power { > + label = "Power"; > + gpios = <&gpio TEGRA_GPIO(Q, 0) GPIO_ACTIVE_LOW>; > + linux,code = <116>; /* KEY_POWER */ > + gpio-key,wakeup; > + }; > + > + home { Similarly, the nodes inside gpio-keys should also be sorted alphabetically.