* Re: Issue with porting i2c driver to k3.10 (iio) [not found] <CAGH3droX_J9JJ60EP6d62Sh6MK6T5WvYTq+uwcmJkwb0c1Yurg@mail.gmail.com> @ 2013-07-04 16:19 ` Greg KH 2013-07-06 11:47 ` Jonathan Cameron 0 siblings, 1 reply; 2+ messages in thread From: Greg KH @ 2013-07-04 16:19 UTC (permalink / raw) To: Oleksandr Kravchenko; +Cc: linux-iio, linux-kernel, arnd, jic23 On Thu, Jul 04, 2013 at 04:16:43PM +0300, Oleksandr Kravchenko wrote: > Hi All, > > I wrote i2c driver for APDS-9300 light sensor in drivers/misc, but I have some > questions regarding upstreaming of it. > 1. It works properly in kernel-3.4, but it works very slow in kernel-3.10 (on > mutex and i2c operations, particulary on mutex_lock() and i2c_smbus_read_data > ()). Does anyone know why this issue may be occurred? What is "slow"? Have you run 'perf' on the driver to see where it is spending time? > 2. Can I send this driver without using Industrial I/O framework? No, why would you even want to? greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Issue with porting i2c driver to k3.10 (iio) 2013-07-04 16:19 ` Issue with porting i2c driver to k3.10 (iio) Greg KH @ 2013-07-06 11:47 ` Jonathan Cameron 0 siblings, 0 replies; 2+ messages in thread From: Jonathan Cameron @ 2013-07-06 11:47 UTC (permalink / raw) To: Greg KH; +Cc: Oleksandr Kravchenko, linux-iio, linux-kernel, arnd, jic23 On 07/04/2013 05:19 PM, Greg KH wrote: > On Thu, Jul 04, 2013 at 04:16:43PM +0300, Oleksandr Kravchenko wrote: >> Hi All, >> >> I wrote i2c driver for APDS-9300 light sensor in drivers/misc, but I have some >> questions regarding upstreaming of it. >> 1. It works properly in kernel-3.4, but it works very slow in kernel-3.10 (on >> mutex and i2c operations, particulary on mutex_lock() and i2c_smbus_read_data >> ()). Does anyone know why this issue may be occurred? > > What is "slow"? Have you run 'perf' on the driver to see where it is > spending time? > >> 2. Can I send this driver without using Industrial I/O framework? > > No, why would you even want to? Looks like a fairly standard light sensor so drivers/iio/light. Actually very close in design to some of the TAOS parts such as those supported by the tsl2563 driver if you want a reference driver to compare with. Jonathan ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-06 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAGH3droX_J9JJ60EP6d62Sh6MK6T5WvYTq+uwcmJkwb0c1Yurg@mail.gmail.com>
2013-07-04 16:19 ` Issue with porting i2c driver to k3.10 (iio) Greg KH
2013-07-06 11:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox