From: Dave Hansen <dave.hansen@intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, dave.hansen@linux.intel.com, ak@linux.intel.com,
jolsa@redhat.com
Subject: Re: [PATCH] perf: fix interrupt handler timing harness
Date: Mon, 08 Jul 2013 07:34:48 -0700 [thread overview]
Message-ID: <51DACE08.5030109@intel.com> (raw)
In-Reply-To: <20130704223010.GA30625@quad>
On 07/04/2013 03:30 PM, Stephane Eranian wrote:
> There was an misunderstanding on the API of the do_div()
> macro. It returns the remainder of the division and this
> was not what the function expected leading to disabling the
> interrupt latency watchdog.
"Misunderstanding" is a very kind term for what I did there. Stephane,
were you actually running in to the new cpu limit, or were you just
trying to update kernel.perf_event_max_sample_rate?
BTW, I also did the same thing in 2ab00456:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2ab00456ea8a0d79acb1390659b98416111880b2
I'll have a patch out shortly for that one, but its damage would be
limited to a bogus printk.
next prev parent reply other threads:[~2013-07-08 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 22:30 [PATCH] perf: fix interrupt handler timing harness Stephane Eranian
2013-07-05 6:54 ` Ingo Molnar
2013-07-05 9:54 ` [tip:perf/urgent] perf: Fix " tip-bot for Stephane Eranian
2013-07-08 14:34 ` Dave Hansen [this message]
2013-07-08 18:08 ` [PATCH] perf: fix " Stephane Eranian
2013-07-08 20:05 ` Dave Hansen
2013-07-08 20:20 ` Stephane Eranian
2013-07-08 20:34 ` Dave Hansen
2013-07-08 20:54 ` Andi Kleen
2013-07-08 20:56 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DACE08.5030109@intel.com \
--to=dave.hansen@intel.com \
--cc=ak@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox