From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753596Ab3GIOEN (ORCPT ); Tue, 9 Jul 2013 10:04:13 -0400 Received: from mail.free-electrons.com ([94.23.35.102]:35771 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063Ab3GIOEK (ORCPT ); Tue, 9 Jul 2013 10:04:10 -0400 Message-ID: <51DC1858.8010008@free-electrons.com> Date: Tue, 09 Jul 2013 16:04:08 +0200 From: Alexandre Belloni Organization: Free Electrons User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Jonathan Cameron CC: Lars-Peter Clausen , Shawn Guo , Jonathan Cameron , jimwall@q.com, brian@crystalfontz.com, Maxime Ripard , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, Rob Landley , Rob Herring , Grant Likely Subject: Re: [PATCHv3 1/3] iio: Add Nuvoton NAU7802 ADC driver References: <1372094699-3832-1-git-send-email-alexandre.belloni@free-electrons.com> <1372094699-3832-2-git-send-email-alexandre.belloni@free-electrons.com> <51D53B72.6020309@metafoo.de> <51D7F044.9040205@kernel.org> In-Reply-To: <51D7F044.9040205@kernel.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, I don't actually see it in iio.git on kernel.org, am I doing something wrong ? On 06/07/2013 12:24, Jonathan Cameron wrote: > On 07/04/2013 10:08 AM, Lars-Peter Clausen wrote: >> On 06/24/2013 07:24 PM, Alexandre Belloni wrote: >>> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable >>> gain and sampling rates. >>> >>> Signed-off-by: Alexandre Belloni >>> Signed-off-by: Maxime Ripard >> Reviewed-by: Lars-Peter Clausen >> > Applied to the togreg branch of iio.git (with a few little tweaks). > > There was some fuzz that required manual fixing because of another driver merge so > please check I didn't foul anything up with this or the other bits below. > > There were two trivial missing unlocks on error paths in the read_raw function that > I've fixed up (Coccinelle found these for me - if you can I would always advise > running sparse, coccicheck and ideally smatch before submitting patches). > > I fixed up the comments because if there is one thing I hate bothering > with it is delightful patches that just fix this stuff. Much better > to do it now given it took 20 secs ;) > >> One remark though. Multiline comments should be like >> >> /* >> * foo >> * bar >> */ >> >> not >> >> /* foo >> * bar >> */ >> >> But not need to resend the patch just for this >> >> - Lars >> -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com