From: Dave Young <dyoung@redhat.com>
To: Matt Fleming <matt.fleming@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Matthew Garrett <matthew.garrett@nebula.com>
Subject: Re: uefi boot hang (bisected)
Date: Thu, 11 Jul 2013 09:57:37 +0800 [thread overview]
Message-ID: <51DE1111.7040809@redhat.com> (raw)
In-Reply-To: <51DD553B.1080701@intel.com>
On 07/10/2013 08:36 PM, Matt Fleming wrote:
> On 10/07/13 07:36, Dave Young wrote:
>> Another problem is: With this patch applied I tried noefi boot, but
>> kernel paniced, looks like efivar_init depends on efi runtime. Below
>> patches works for me about noefi boot though I'm not sure if it's a
>> right fix, please review.
>
> It makes more sense to check in efivars.c, since none of that file can
> function without runtime serivces.
>
> Could you try the following patch?
It works, thanks for the patch.
Tested-by: Dave Young <dyoung@redhat.com>
>
> ---
>
> diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c
> index 8bd1bb6..8a7432a 100644
> --- a/drivers/firmware/efi/efivars.c
> +++ b/drivers/firmware/efi/efivars.c
> @@ -583,6 +583,9 @@ int efivars_sysfs_init(void)
> struct kobject *parent_kobj = efivars_kobject();
> int error = 0;
>
> + if (!efi_enabled(EFI_RUNTIME_SERVICES))
> + return -ENODEV;
> +
> /* No efivars has been registered yet */
> if (!parent_kobj)
> return 0;
>
--
Thanks
Dave
prev parent reply other threads:[~2013-07-11 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 6:36 uefi boot hang (bisected) Dave Young
2013-07-10 12:36 ` Matt Fleming
2013-07-11 1:57 ` Dave Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DE1111.7040809@redhat.com \
--to=dyoung@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matthew.garrett@nebula.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).