From: Yijing Wang <wangyijing@huawei.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
Rafael <rjw@sisk.pl>, Hanjun Guo <guohanjun@huawei.com>,
<jiang.liu@huawei.com>, Oliver Neukum <oneukum@suse.de>,
Gu Zheng <guz.fnst@cn.fujitsu.com>
Subject: Re: [PATCH 2/2] PCI,pciehp: avoid add a device already exist during pciehp_resume
Date: Thu, 11 Jul 2013 11:55:04 +0800 [thread overview]
Message-ID: <51DE2C98.5030803@huawei.com> (raw)
In-Reply-To: <1373357261.1633.4.camel@x61.thuisdomein>
>> We should do nothing in pciehp_resume, but we call
>> pciehp_enable_slot(), so some uncomfortable messages show like above.
>> In this case, we can improve it a little by add a guard
>> if (!list_empty(bus->devices)).
>
> Great!
>
> I'm currently trying to bisect another problem, but hope to test this
> patch (and the preceding patch it apparently needs) in a few days.
> Please feel free to prod me if you think testing is needed but I'm
> taking to long to report back.
Hi Paul,
Can you provide the lspci -vvv and lspci -xxxx info messages ?
I want to confirm your hardware information which cause your resume error.
You can get these messages in any kernel version, that's ok.
When you suspend and resume the system, the wireless card is always present in pcie slot, right?
Thanks!
Yijing.
>
>
> .
>
--
Thanks!
Yijing
next prev parent reply other threads:[~2013-07-11 3:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 7:56 [PATCH 2/2] PCI,pciehp: avoid add a device already exist during pciehp_resume Yijing Wang
2013-07-09 8:07 ` Paul Bolle
2013-07-09 8:18 ` Yijing Wang
2013-07-11 3:55 ` Yijing Wang [this message]
2013-07-11 10:19 ` Paul Bolle
2013-07-12 1:49 ` Yijing Wang
2013-07-09 22:27 ` Bjorn Helgaas
2013-07-10 3:00 ` Yijing Wang
2013-07-10 20:27 ` Bjorn Helgaas
2013-07-11 2:33 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DE2C98.5030803@huawei.com \
--to=wangyijing@huawei.com \
--cc=bhelgaas@google.com \
--cc=guohanjun@huawei.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=pebolle@tiscali.nl \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox