From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Wolfram Sang <wsa@the-dreams.de>, <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 08/12] drivers/net/ethernet/cadence: don't use devm_pinctrl_get_select_default() in probe
Date: Thu, 11 Jul 2013 09:40:02 +0200 [thread overview]
Message-ID: <51DE6152.20406@atmel.com> (raw)
In-Reply-To: <1373471889-18107-8-git-send-email-wsa@the-dreams.de>
On 10/07/2013 17:57, Wolfram Sang :
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for setting the default pins. Compile tested only.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks Wolfram.
Bye,
> ---
> drivers/net/ethernet/cadence/at91_ether.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c
> index 3f19571..bb5d63f 100644
> --- a/drivers/net/ethernet/cadence/at91_ether.c
> +++ b/drivers/net/ethernet/cadence/at91_ether.c
> @@ -29,7 +29,6 @@
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_net.h>
> -#include <linux/pinctrl/consumer.h>
>
> #include "macb.h"
>
> @@ -309,7 +308,6 @@ static int __init at91ether_probe(struct platform_device *pdev)
> struct resource *regs;
> struct net_device *dev;
> struct phy_device *phydev;
> - struct pinctrl *pinctrl;
> struct macb *lp;
> int res;
> u32 reg;
> @@ -319,15 +317,6 @@ static int __init at91ether_probe(struct platform_device *pdev)
> if (!regs)
> return -ENOENT;
>
> - pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> - if (IS_ERR(pinctrl)) {
> - res = PTR_ERR(pinctrl);
> - if (res == -EPROBE_DEFER)
> - return res;
> -
> - dev_warn(&pdev->dev, "No pinctrl provided\n");
> - }
> -
> dev = alloc_etherdev(sizeof(struct macb));
> if (!dev)
> return -ENOMEM;
>
--
Nicolas Ferre
next prev parent reply other threads:[~2013-07-11 7:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 15:57 [PATCH 01/12] drivers/gpu/drm/tilcdc: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
2013-07-10 15:57 ` [PATCH 02/12] drivers/i2c/busses: " Wolfram Sang
2013-08-07 15:37 ` Wolfram Sang
2013-07-10 15:57 ` [PATCH 03/12] drivers/misc: " Wolfram Sang
2013-07-10 23:13 ` Arnd Bergmann
2013-07-20 17:45 ` Linus Walleij
2013-07-20 17:50 ` Greg KH
2013-07-10 15:57 ` [PATCH 04/12] drivers/mmc/host: " Wolfram Sang
2013-07-10 19:57 ` Marek Vasut
2013-07-12 3:39 ` Barry Song
2013-07-10 15:57 ` [PATCH 05/12] drivers/mtd/nand: " Wolfram Sang
2013-08-02 15:51 ` Artem Bityutskiy
2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang
2013-07-11 2:14 ` Huang Shijie
2013-07-11 2:19 ` Huang Shijie
2013-07-20 17:48 ` Linus Walleij
2013-08-02 15:37 ` Artem Bityutskiy
2013-07-10 15:57 ` [PATCH 07/12] drivers/net/can/c_can: " Wolfram Sang
2013-07-10 21:02 ` Marc Kleine-Budde
2013-07-10 21:14 ` David Miller
2013-07-12 0:18 ` David Miller
2013-07-10 15:57 ` [PATCH 08/12] drivers/net/ethernet/cadence: " Wolfram Sang
2013-07-11 7:40 ` Nicolas Ferre [this message]
2013-07-12 0:19 ` David Miller
2013-07-10 15:57 ` [PATCH 09/12] drivers/net/ieee802154: " Wolfram Sang
2013-07-12 0:19 ` David Miller
2013-07-10 15:57 ` [PATCH 10/12] drivers/pwm: " Wolfram Sang
2013-07-10 15:57 ` [PATCH 11/12] drivers/tty/serial: " Wolfram Sang
2013-07-11 7:40 ` Nicolas Ferre
2013-07-20 17:46 ` Linus Walleij
2013-07-20 17:50 ` Greg KH
2013-07-10 15:57 ` [PATCH 12/12] drivers/video: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DE6152.20406@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox