From: Chen Gang <gang.chen@asianux.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph()
Date: Fri, 12 Jul 2013 09:58:51 +0800 [thread overview]
Message-ID: <51DF62DB.3010409@asianux.com> (raw)
In-Reply-To: <1373593261.17876.61.camel@gandalf.local.home>
On 07/12/2013 09:41 AM, Steven Rostedt wrote:
> On Fri, 2013-07-12 at 07:51 +0800, Chen Gang wrote:
>
>> > Hmm, can all trace_selftest_startup_* (*selftest* in trace_selftest.c)
>> > use '__init', so not waste memory keeping them around ?
> Yeah, they should all be set to __init, but that's pretty low on the
> totem poll, as distros don't enable selftests in their main kernels.
Excuse me, my English is not quite well, I guess your meaning is:
they should all be set to '__init', although it is minor in real world.
Is it correct ?
For me, I recommend to let all *selftest* as the same: "all add '
__init' or none add '__init'" (if choose add, all report warnings).
Is it suitable to still send new related patch for it ? If so, could
you provide your suggesting choice (all add, or none add) ?
Thanks.
--
Chen Gang
next prev parent reply other threads:[~2013-07-12 1:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 0:31 [PATCH] kernel: trace: remove __init from race_selftest_startup_function() and trace_selftest_startup_function_graph() Chen Gang
2013-07-11 16:47 ` Steven Rostedt
2013-07-11 23:51 ` Chen Gang
2013-07-12 1:41 ` Steven Rostedt
2013-07-12 1:58 ` Chen Gang [this message]
2013-07-12 2:38 ` Steven Rostedt
2013-07-12 3:04 ` Chen Gang
2013-07-12 7:20 ` Chen Gang
2013-07-15 2:12 ` Chen Gang
2013-07-15 16:20 ` Steven Rostedt
2013-07-16 0:22 ` Chen Gang
2013-07-17 0:52 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DF62DB.3010409@asianux.com \
--to=gang.chen@asianux.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox