public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: David Ahern <dsahern@gmail.com>
Cc: Dave Jones <davej@redhat.com>, Ingo Molnar <mingo@kernel.org>,
	Markus Trippelsdorf <markus@trippelsdorf.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Peter Anvin <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: Yet more softlockups.
Date: Fri, 12 Jul 2013 13:13:15 -0700	[thread overview]
Message-ID: <51E0635B.6010003@sr71.net> (raw)
In-Reply-To: <51E045E0.8020702@gmail.com>

I added the WARN_ONCE() the first time we enable a perf event:  The
watchdog code looks to use perf these days:

> [    1.003260] ------------[ cut here ]------------
> [    1.007943] WARNING: at /home/davehans/linux.git/arch/x86/kernel/cpu/perf_event.c:471 x86_pmu_event_init+0x249/0x430()
> [    1.018906] Modules linked in:
> [    1.021999] CPU: 0 PID: 11 Comm: watchdog/0 Not tainted 3.10.0-05973-gd2b4a64-dirty #190
> [    1.030313] Hardware name: FUJITSU-SV PRIMEQUEST 1800E2/SB, BIOS PRIMEQUEST 1000 Series BIOS Version 1.24 09/14/2011
> [    1.041093]  ffffffff819dc0b8 ffff881fd33e3c98 ffffffff816270c5 0000000000001a9d
> [    1.048601]  0000000000000009 ffff881fd33e3cd8 ffffffff81090f50 ffff881fd3248048
> [    1.056112]  ffff881fff26a800 ffff881fff26a800 0000000000000000 0000000000000000
> [    1.063621] Call Trace:
> [    1.066106]  [<ffffffff816270c5>] dump_stack+0x55/0x76
> [    1.071313]  [<ffffffff81090f50>] warn_slowpath_common+0x70/0xa0
> [    1.077410]  [<ffffffff81090f9a>] warn_slowpath_null+0x1a/0x20
> [    1.083330]  [<ffffffff81060cb9>] x86_pmu_event_init+0x249/0x430
> [    1.089427]  [<ffffffff81144f0f>] perf_init_event+0xef/0x130
> [    1.095170]  [<ffffffff811452a8>] perf_event_alloc+0x358/0x4a0
> [    1.101091]  [<ffffffff810ca27d>] ? set_next_entity+0x3d/0x80
> [    1.106924]  [<ffffffff811081a0>] ? touch_nmi_watchdog+0x80/0x80
> [    1.113018]  [<ffffffff8114570e>] perf_event_create_kernel_counter+0x2e/0xe0
> [    1.120176]  [<ffffffff8110835d>] watchdog_enable+0xfd/0x1e0
> [    1.125919]  [<ffffffff810bf8e3>] smpboot_thread_fn+0xe3/0x1f0
> [    1.131839]  [<ffffffff810bf800>] ? smpboot_unregister_percpu_thread+0x50/0x50
> [    1.139250]  [<ffffffff810b7d10>] kthread+0xc0/0xd0
> [    1.144200]  [<ffffffff810b7c50>] ? flush_kthread_worker+0xb0/0xb0
> [    1.150474]  [<ffffffff8163735c>] ret_from_fork+0x7c/0xb0
> [    1.155950]  [<ffffffff810b7c50>] ? flush_kthread_worker+0xb0/0xb0
> [    1.162227] ---[ end trace 32c04e859824e00d ]---

static int watchdog_nmi_enable(unsigned int cpu)
{
...
        /* Try to register using hardware perf events */
        event = perf_event_create_kernel_counter(wd_attr, cpu, NULL, ...

That at least solves the boot-time mystery.

  parent reply	other threads:[~2013-07-12 20:13 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-04  1:55 scheduling while atomic & hang Dave Jones
2013-07-04  2:49 ` Linus Torvalds
2013-07-04  4:43   ` H. Peter Anvin
2013-07-04  7:49   ` Dave Jones
2013-07-04 17:22     ` Linus Torvalds
2013-07-10 20:54     ` J. Bruce Fields
2013-07-04 18:08   ` H. Peter Anvin
2013-07-05  6:51     ` Ingo Molnar
2013-07-05  7:19       ` Frederic Weisbecker
2013-07-05 10:05         ` Ingo Molnar
2013-07-05 19:27       ` Linus Torvalds
2013-07-06  8:02         ` Frederic Weisbecker
2013-07-06  8:07           ` Ingo Molnar
2013-07-05 14:38   ` Yet more softlockups Dave Jones
2013-07-05 15:15     ` Thomas Gleixner
2013-07-05 16:00       ` Dave Jones
2013-07-05 16:02         ` Thomas Gleixner
2013-07-05 16:41           ` H. Peter Anvin
2013-07-05 18:20             ` Seiji Aguchi
2013-07-05 22:21               ` Thomas Gleixner
2013-07-06  7:24         ` Ingo Molnar
2013-07-07  0:24           ` Dave Jones
2013-07-10 15:13           ` Dave Jones
2013-07-10 15:20             ` Markus Trippelsdorf
2013-07-10 15:40               ` Dave Jones
2013-07-12 10:31                 ` Ingo Molnar
2013-07-12 15:38                   ` Dave Hansen
2013-07-12 15:45                     ` Dave Jones
2013-07-12 15:55                       ` Dave Hansen
2013-07-12 17:00                         ` Dave Jones
2013-07-12 17:12                       ` David Ahern
2013-07-12 17:18                         ` Dave Jones
2013-07-12 17:40                           ` David Ahern
2013-07-12 17:50                             ` Dave Jones
2013-07-12 18:07                               ` David Ahern
2013-07-12 18:22                                 ` Dave Hansen
2013-07-12 20:13                                 ` Dave Hansen [this message]
2013-07-13  1:40                       ` Vince Weaver
2013-07-10 15:39             ` Vince Weaver
2013-07-10 15:45               ` Dave Jones
2013-07-10 21:54               ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E0635B.6010003@sr71.net \
    --to=dave@sr71.net \
    --cc=davej@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox