Re: [PATCH] x86: make sure IDT is page aligned

Kees Cook
2013-07-12T22:43:12Z

That was the busted patch. See the v2 I sent. Only 64-bit needs
alignment. And after looking more at it, the idt in head_64.S could be
entirely dropped in favor of using the one in arch/x86/kernel/traps.c
(after moving it out of the #ifdef.

-Kees

On Fri, Jul 12, 2013 at 3:28 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 07/12/2013 11:30 AM, Kees Cook wrote:
>>
>> - .word 0 # 32-bit align idt_desc.address
>> + .word PAGE_SIZE # page align idt_desc.address
>>
>
> ... and this is totally confused. This didn't change alignment one
> iota, it only put the value 4096 into the padding.
>
> -hpa
>

--
Kees Cook
Chrome OS Security