From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758045Ab3GMBPY (ORCPT ); Fri, 12 Jul 2013 21:15:24 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:46361 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757993Ab3GMBPW (ORCPT ); Fri, 12 Jul 2013 21:15:22 -0400 Message-ID: <51E0AA24.6070203@cogentembedded.com> Date: Sat, 13 Jul 2013 05:15:16 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Greg KH CC: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH] misc: add driver for Renesas R-Car Gyro-ADC/speed-pulse interfaces References: <201307130351.42967.sergei.shtylyov@cogentembedded.com> <20130713005702.GA14788@kroah.com> In-Reply-To: <20130713005702.GA14788@kroah.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. Can't get to sleep, sigh... On 07/13/2013 04:57 AM, Greg KH wrote: >> Add the driver for Gyro-ADC/speed-pulse interfaces found in Renesas R-Car SoCs. >> Though being two separate devices, they have to be driven together because of >> the shared start/stop register (located in Gyro-ADC still). At this time, only >> speed-pulse interface is fully supported, the Gyro-ADC is just initialized and >> started/stopped synchronously with the speed-pulse interface. A user interface >> is implemented via several sysfs files which allow to read and reset the speed- >> pulse interface's registers. > If you modify/create/remove sysfs files, you also have to document them > in Documentation/ABI/ which is missing from this patch. I've looked there and didn't find the documentation for my closest model driver, drivers/misc/ti_dac7512.c (or for many other drivers), so I thought I too can do without it. > Your sysfs files are also being created in a "racy" way, i.e. after > userspace is told about the device, please fix that as well. Not sure I understand you. Could you elaborate? > And are you sure you want to control this through sysfs? There's no > other better user/kernel apis for it? I found none, besides ioctl(), as the device driven is rather unique. But I thought that sysfs is "ioctl() today", so I went with it... > thanks, > greg k-h WBR, Sergei