From: Dong Fang <yp.fangdong@gmail.com>
To: Dong Fang <yp.fangdong@gmail.com>
Cc: viro@zeniv.linux.org.uk, nyc@holomorphy.com, fweisbec@gmail.com,
dhowells@redhat.com, mchehab@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kprobes: fix compiler warning
Date: Sun, 14 Jul 2013 13:48:53 -0400 [thread overview]
Message-ID: <51E2E485.9090902@gmail.com> (raw)
In-Reply-To: <1372689999-30921-1-git-send-email-yp.fangdong@gmail.com>
On 07/01/2013 10:46 AM, Dong Fang wrote:
> Fix the following compiler warning of uninitialized variable
>
> kernel/kprobes.c: In function 'register_kprobe':
> kernel/kprobes.c:1493: warning: 'probed_mod' may be used uninitialized in this function
>
> Signed-off-by: Dong Fang <yp.fangdong@gmail.com>
> ---
> kernel/kprobes.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index bddf3b2..7a5b2b1 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1490,7 +1490,7 @@ int __kprobes register_kprobe(struct kprobe *p)
> {
> int ret;
> struct kprobe *old_p;
> - struct module *probed_mod;
> + struct module *probed_mod = NULL;
> kprobe_opcode_t *addr;
>
> /* Adjust probe address from symbol */
>
can anybody take a look at this patch and give me some feedback? thx
prev parent reply other threads:[~2013-07-14 5:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 14:46 [PATCH v2] kprobes: fix compiler warning Dong Fang
2013-07-14 17:48 ` Dong Fang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E2E485.9090902@gmail.com \
--to=yp.fangdong@gmail.com \
--cc=dhowells@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=nyc@holomorphy.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox