public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov@parallels.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
	<devel@openvz.org>, <pjt@google.com>
Subject: Re: [PATCH RFC] sched: move h_load calculation to task_h_load
Date: Mon, 15 Jul 2013 14:00:42 +0400	[thread overview]
Message-ID: <51E3C84A.5090403@parallels.com> (raw)
In-Reply-To: <20130715082853.GM17211@twins.programming.kicks-ass.net>

On 07/15/2013 12:28 PM, Peter Zijlstra wrote:
> OK, fair enough. It does somewhat rely on us getting the single
> rq->clock update thing right, but that should be ok.

Frankly, I doubt that rq->clock is the right thing to use here, because 
it can be updated very frequently under some conditions, so that 
cfs_rq->h_load can get updated several times during the same balance 
run. Perhaps, jiffies would suit better for that purpose. This would 
work as h_load update throttler similar to how it works now (I mean 
rq->h_load_throttle in update_h_load()).

If there is something else you don't like/have some thoughts on, please 
share - I'll try to improve.

Thank you for your feedback.

> But yeah, when you have stupid many cgroups we quickly need less h_load
> instances than there are cgroups.

  reply	other threads:[~2013-07-15 10:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-13  8:47 [PATCH RFC] sched: move h_load calculation to task_h_load Vladimir Davydov
2013-07-15  8:28 ` Peter Zijlstra
2013-07-15 10:00   ` Vladimir Davydov [this message]
2013-07-15 10:59     ` Peter Zijlstra
2013-07-15 13:49       ` [PATCH v2] " Vladimir Davydov
2013-07-16 15:50         ` Peter Zijlstra
2013-07-24  3:56         ` [tip:perf/core] sched: Move h_load calculation to task_h_load() tip-bot for Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E3C84A.5090403@parallels.com \
    --to=vdavydov@parallels.com \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox