public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: <agordeev@redhat.com>, <tj@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: AHCI: ahci Driver crash in ahci_host_activate
Date: Mon, 15 Jul 2013 09:08:40 -0500	[thread overview]
Message-ID: <51E40268.3030009@amd.com> (raw)

I ran into a crash during booting with the latest 3.11.0-rc1.  After 
investigation, the crash was triggered by the patch below where the "pp" 
is NULL in some cases.

Suravee

commit b29900e62598cecd519c9ab2b8e4d03f8ebf702d
Author: Alexander Gordeev <agordeev@redhat.com>
Date:   Wed May 22 08:53:48 2013 +0900

     AHCI: Make distinct names for ports in /proc/interrupts

     Currently all interrupts assigned to AHCI ports show up in
     '/proc/interrupts' as 'ahci'. This fix adds port numbers as
     suffixes and hence makes the descriptions distinct.

     Reported-by: Jan Beulich <JBeulich@suse.com>
     Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
     Signed-off-by: Tejun Heo <tj@kernel.org>

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 251e57d..4d1c672 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1142,9 +1142,11 @@ int ahci_host_activate(struct ata_host *host, int 
irq, unsigned int n_msis)
                 return rc;

         for (i = 0; i < host->n_ports; i++) {
+               struct ahci_port_priv *pp = host->ports[i]->private_data;
+
                 rc = devm_request_threaded_irq(host->dev,
                         irq + i, ahci_hw_interrupt, ahci_thread_fn, 
IRQF_SHARED,
-                       dev_driver_string(host->dev), host->ports[i]);
+                       pp->irq_desc, host->ports[i]);
                 if (rc)
                         goto out_free_irqs;
         }


             reply	other threads:[~2013-07-15 14:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 14:08 Suravee Suthikulanit [this message]
2013-07-22 21:40 ` AHCI: ahci Driver crash in ahci_host_activate Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E40268.3030009@amd.com \
    --to=suravee.suthikulpanit@amd.com \
    --cc=agordeev@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox