From: David Daney <ddaney.cavm@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
David Daney <david.daney@cavium.com>,
Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH] scripts: remove unused function in sortextable.c
Date: Mon, 15 Jul 2013 09:55:56 -0700 [thread overview]
Message-ID: <51E4299C.3080905@gmail.com> (raw)
In-Reply-To: <1373479418-7079-1-git-send-email-artagnon@gmail.com>
On 07/10/2013 11:03 AM, Ramkumar Ramachandra wrote:
> Cc: David Daney <david.daney@cavium.com>
> Cc: Michal Marek <mmarek@suse.cz>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
I haven't tested it, but it looks plausible.
Acked-by: David Daney <david.daney@cavium.com>
> ---
> Trivial. I wonder why make didn't tell us?
>
> scripts/sortextable.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/scripts/sortextable.c b/scripts/sortextable.c
> index f9ce116..7c2310c 100644
> --- a/scripts/sortextable.c
> +++ b/scripts/sortextable.c
> @@ -64,14 +64,6 @@ fail_file(void)
> longjmp(jmpenv, SJ_FAIL);
> }
>
> -static void __attribute__((noreturn))
> -succeed_file(void)
> -{
> - cleanup();
> - longjmp(jmpenv, SJ_SUCCEED);
> -}
> -
> -
> /*
> * Get the whole file as a programming convenience in order to avoid
> * malloc+lseek+read+free of many pieces. If successful, then mmap
>
next prev parent reply other threads:[~2013-07-15 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 18:03 [PATCH] scripts: remove unused function in sortextable.c Ramkumar Ramachandra
2013-07-15 16:55 ` David Daney [this message]
2013-07-25 14:21 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E4299C.3080905@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=artagnon@gmail.com \
--cc=david.daney@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).