[PATCH] extcon: palmas: remove assigning "edev.name" to palmas

[PATCH] extcon: palmas: remove assigning "edev.name" to palmas

[Kishon Vijay Abraham I]

of_extcon_get_extcon_dev() uses dev_name for getting the reference
to the extcon device. If the extcon driver assigns a different
name other than dev_name, of_extcon_get_extcon_dev() wouldn't
be able to find the reference to the extcon device. Since the
client drivers of extcon-palmas would be using
of_extcon_get_extcon_dev(), removed assigning edev.name
in extcon-palmas.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/extcon/extcon-palmas.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index b752a0a..7350ac2 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -172,7 +172,6 @@ static int palmas_usb_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, palmas_usb);
 
-	palmas_usb->edev.name = "palmas-usb";
 	palmas_usb->edev.supported_cable = palmas_extcon_cable;
 	palmas_usb->edev.mutually_exclusive = mutually_exclusive;
 
-- 
1.7.10.4

Re: [PATCH] extcon: palmas: remove assigning "edev.name" to palmas

[Chanwoo Choi]

On 06/14/2013 10:18 PM, Kishon Vijay Abraham I wrote:
> of_extcon_get_extcon_dev() uses dev_name for getting the reference
> to the extcon device. If the extcon driver assigns a different
> name other than dev_name, of_extcon_get_extcon_dev() wouldn't
> be able to find the reference to the extcon device. Since the
> client drivers of extcon-palmas would be using
> of_extcon_get_extcon_dev(), removed assigning edev.name
> in extcon-palmas.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/extcon/extcon-palmas.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index b752a0a..7350ac2 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -172,7 +172,6 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, palmas_usb);
>  
> -	palmas_usb->edev.name = "palmas-usb";
>  	palmas_usb->edev.supported_cable = palmas_extcon_cable;
>  	palmas_usb->edev.mutually_exclusive = mutually_exclusive;
>  
> 

This patch is applied. Sorry for missing this patch.
You can check it on extcon-linus repo.
- http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-linus

Thanks,
Chanwoo Choi