* [PATCH] fs: 9p: use strlcpy instead of strncpy
@ 2013-07-16 7:33 Chen Gang
0 siblings, 0 replies; only message in thread
From: Chen Gang @ 2013-07-16 7:33 UTC (permalink / raw)
To: ericvh, rminnich, lucho; +Cc: v9fs-developer, linux-kernel@vger.kernel.org
For 'NULL' terminated string, recommend always to be ended by zero.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
fs/9p/vfs_inode.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 25b018e..94de6d1 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -146,7 +146,7 @@ static umode_t p9mode2unixmode(struct v9fs_session_info *v9ses,
char type = 0, ext[32];
int major = -1, minor = -1;
- strncpy(ext, stat->extension, sizeof(ext));
+ strlcpy(ext, stat->extension, sizeof(ext));
sscanf(ext, "%c %u %u", &type, &major, &minor);
switch (type) {
case 'c':
@@ -1186,7 +1186,7 @@ v9fs_stat2inode(struct p9_wstat *stat, struct inode *inode,
* this even with .u extension. So check
* for non NULL stat->extension
*/
- strncpy(ext, stat->extension, sizeof(ext));
+ strlcpy(ext, stat->extension, sizeof(ext));
/* HARDLINKCOUNT %u */
sscanf(ext, "%13s %u", tag_name, &i_nlink);
if (!strncmp(tag_name, "HARDLINKCOUNT", 13))
--
1.7.7.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-07-16 7:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-16 7:33 [PATCH] fs: 9p: use strlcpy instead of strncpy Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox