[PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

[PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

[Wei Ni]

Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.

This series is v2, previous version patches:
[RFC 1/9]: http://thread.gmane.org/gmane.linux.power-management.general/31056
[v1]: http://thread.gmane.org/gmane.linux.ports.tegra/11713/
[v2]: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg465561.html

Changes from v2:
1. remove the label "nct1008".

Changes from v1:
1. add vendor strings "onnn" for nct1008 node.

Changes from RFC:
1. Enable it for Tegra114 Dalmore.

Wei Ni (2):
  ARM: dt: t30 cardhu: add dt entry for nct1008
  ARM: dt: t114 dalmore: add dt entry for nct1008

 arch/arm/boot/dts/tegra114-dalmore.dts |    7 +++++++
 arch/arm/boot/dts/tegra30-cardhu.dtsi  |    7 +++++++
 2 files changed, 14 insertions(+)

-- 
1.7.9.5

[PATCH v3 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008

[Wei Ni]

Enable thermal sensor nct1008 for t30 cardhu.

Signed-off-by: Wei Ni <wni@nvidia.com>
---
 arch/arm/boot/dts/tegra30-cardhu.dtsi |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index f65b53d..e5759ca 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -286,6 +286,13 @@
 				};
 			};
 		};
+
+		nct1008 {
+			compatible = "onnn,nct1008";
+			reg = <0x4c>;
+			interrupt-parent = <&gpio>;
+			interrupts = <TEGRA_GPIO(CC, 2) IRQ_TYPE_LEVEL_LOW>;
+		};
 	};
 
 	spi@7000da00 {
-- 
1.7.9.5

[PATCH v3 2/2] ARM: dt: t114 dalmore: add dt entry for nct1008

[Wei Ni]

Enable thermal sensor nct1008 for t114 dalmore.

Signed-off-by: Wei Ni <wni@nvidia.com>
---
 arch/arm/boot/dts/tegra114-dalmore.dts |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index cb640eb..47ec7eb 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -738,6 +738,13 @@
 			realtek,ldo1-en-gpios =
 				<&gpio TEGRA_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
 		};
+
+		nct1008 {
+			compatible = "onnn,nct1008";
+			reg = <0x4c>;
+			interrupt-parent = <&gpio>;
+			interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
+		};
 	};
 
 	i2c@7000d000 {
-- 
1.7.9.5

Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

[Stephen Warren]

On 07/12/2013 01:49 AM, Wei Ni wrote:
> Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.

I have applied the series to Tegra's for-3.12/dt branch.

Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

[Stephen Warren]

On 07/15/2013 10:48 AM, Stephen Warren wrote:
> On 07/12/2013 01:49 AM, Wei Ni wrote:
>> Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
> 
> I have applied the series to Tegra's for-3.12/dt branch.

Actually, I see the following on Dalmore (although Cardhu works):

[   29.448539] lm90 0-004c: Register 0x4 read failed (-121)
[   29.453930] lm90 0-004c: Failed to read convrate register!
[   29.460034] lm90 0-004c: Register 0x3 read failed (-121)
[   29.465408] lm90 0-004c: Initialization failed!

So, there's something wrong here, and I've dropped the patch for
Dalmore. Does this patch actually work for you?

Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

[Wei Ni]

On 07/16/2013 01:13 AM, Stephen Warren wrote:
> On 07/15/2013 10:48 AM, Stephen Warren wrote:
>> On 07/12/2013 01:49 AM, Wei Ni wrote:
>>> Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
>>
>> I have applied the series to Tegra's for-3.12/dt branch.
> 
> Actually, I see the following on Dalmore (although Cardhu works):
> 
> [   29.448539] lm90 0-004c: Register 0x4 read failed (-121)
> [   29.453930] lm90 0-004c: Failed to read convrate register!
> [   29.460034] lm90 0-004c: Register 0x3 read failed (-121)
> [   29.465408] lm90 0-004c: Initialization failed!
> 
> So, there's something wrong here, and I've dropped the patch for
> Dalmore. Does this patch actually work for you?
> 
I test it with the Chrome u-boot, the lm90 works fine.
But today, if I tried to use the uboot from
git://git.denx.de/u-boot-tegra.git, I can repo your errors, it seems the
i2c can't work, the lm90 driver read register failed.
I traced it, but can't find the root cause yet.

Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

[Wei Ni]

On 07/16/2013 07:14 PM, Wei Ni wrote:
> On 07/16/2013 01:13 AM, Stephen Warren wrote:
>> On 07/15/2013 10:48 AM, Stephen Warren wrote:
>>> On 07/12/2013 01:49 AM, Wei Ni wrote:
>>>> Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
>>>
>>> I have applied the series to Tegra's for-3.12/dt branch.
>>
>> Actually, I see the following on Dalmore (although Cardhu works):
>>
>> [   29.448539] lm90 0-004c: Register 0x4 read failed (-121)
>> [   29.453930] lm90 0-004c: Failed to read convrate register!
>> [   29.460034] lm90 0-004c: Register 0x3 read failed (-121)
>> [   29.465408] lm90 0-004c: Initialization failed!
>>
>> So, there's something wrong here, and I've dropped the patch for
>> Dalmore. Does this patch actually work for you?
>>
> I test it with the Chrome u-boot, the lm90 works fine.
> But today, if I tried to use the uboot from
> git://git.denx.de/u-boot-tegra.git, I can repo your errors, it seems the
> i2c can't work, the lm90 driver read register failed.
> I traced it, but can't find the root cause yet.

Hi, Stephen
I found the root cause.
In the Chrome u-boot, it will turn on the regulator for the lm90, but in
the upstream u-boot, it didn't do it.
I think this regulator should be handled in the kernel driver, but it
seems the regulator palmas tps65913 didn't be supported on the dalmore yet.
So may be we have to wait the palmas ready on dalmore.

Do you have any suggestions?

Thanks.
Wei.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

[Mikko Perttunen]

On 07/17/2013 11:17 AM, Wei Ni wrote:
> On 07/16/2013 07:14 PM, Wei Ni wrote:
>> On 07/16/2013 01:13 AM, Stephen Warren wrote:
>>> On 07/15/2013 10:48 AM, Stephen Warren wrote:
>>>> On 07/12/2013 01:49 AM, Wei Ni wrote:
>>>>> Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
>>>>
>>>> I have applied the series to Tegra's for-3.12/dt branch.
>>>
>>> Actually, I see the following on Dalmore (although Cardhu works):
>>>
>>> [   29.448539] lm90 0-004c: Register 0x4 read failed (-121)
>>> [   29.453930] lm90 0-004c: Failed to read convrate register!
>>> [   29.460034] lm90 0-004c: Register 0x3 read failed (-121)
>>> [   29.465408] lm90 0-004c: Initialization failed!
>>>
>>> So, there's something wrong here, and I've dropped the patch for
>>> Dalmore. Does this patch actually work for you?
>>>
>> I test it with the Chrome u-boot, the lm90 works fine.
>> But today, if I tried to use the uboot from
>> git://git.denx.de/u-boot-tegra.git, I can repo your errors, it seems the
>> i2c can't work, the lm90 driver read register failed.
>> I traced it, but can't find the root cause yet.
>
> Hi, Stephen
> I found the root cause.
> In the Chrome u-boot, it will turn on the regulator for the lm90, but in
> the upstream u-boot, it didn't do it.
> I think this regulator should be handled in the kernel driver, but it
> seems the regulator palmas tps65913 didn't be supported on the dalmore yet.
> So may be we have to wait the palmas ready on dalmore.

A patch to enable tps65913 on dalmore has already been posted a couple 
of days
ago by Laxman Dewangan, so this shouldn't be too problematic.

>
> Do you have any suggestions?
>
> Thanks.
> Wei.
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

[Wei Ni]

On 07/17/2013 04:23 PM, Mikko Perttunen wrote:
> On 07/17/2013 11:17 AM, Wei Ni wrote:
>> On 07/16/2013 07:14 PM, Wei Ni wrote:
>>> On 07/16/2013 01:13 AM, Stephen Warren wrote:
>>>> On 07/15/2013 10:48 AM, Stephen Warren wrote:
>>>>> On 07/12/2013 01:49 AM, Wei Ni wrote:
>>>>>> Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
>>>>>
>>>>> I have applied the series to Tegra's for-3.12/dt branch.
>>>>
>>>> Actually, I see the following on Dalmore (although Cardhu works):
>>>>
>>>> [   29.448539] lm90 0-004c: Register 0x4 read failed (-121)
>>>> [   29.453930] lm90 0-004c: Failed to read convrate register!
>>>> [   29.460034] lm90 0-004c: Register 0x3 read failed (-121)
>>>> [   29.465408] lm90 0-004c: Initialization failed!
>>>>
>>>> So, there's something wrong here, and I've dropped the patch for
>>>> Dalmore. Does this patch actually work for you?
>>>>
>>> I test it with the Chrome u-boot, the lm90 works fine.
>>> But today, if I tried to use the uboot from
>>> git://git.denx.de/u-boot-tegra.git, I can repo your errors, it seems the
>>> i2c can't work, the lm90 driver read register failed.
>>> I traced it, but can't find the root cause yet.
>>
>> Hi, Stephen
>> I found the root cause.
>> In the Chrome u-boot, it will turn on the regulator for the lm90, but in
>> the upstream u-boot, it didn't do it.
>> I think this regulator should be handled in the kernel driver, but it
>> seems the regulator palmas tps65913 didn't be supported on the dalmore yet.
>> So may be we have to wait the palmas ready on dalmore.
> 
> A patch to enable tps65913 on dalmore has already been posted a couple 
> of days
> ago by Laxman Dewangan, so this shouldn't be too problematic.

Oh, great, I will look it.

> 
>>
>> Do you have any suggestions?
>>
>> Thanks.
>> Wei.
>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>

Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.

[Stephen Warren]

On 07/17/2013 02:17 AM, Wei Ni wrote:
> On 07/16/2013 07:14 PM, Wei Ni wrote:
>> On 07/16/2013 01:13 AM, Stephen Warren wrote:
>>> On 07/15/2013 10:48 AM, Stephen Warren wrote:
>>>> On 07/12/2013 01:49 AM, Wei Ni wrote:
>>>>> Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
>>>>
>>>> I have applied the series to Tegra's for-3.12/dt branch.
>>>
>>> Actually, I see the following on Dalmore (although Cardhu works):
>>>
>>> [   29.448539] lm90 0-004c: Register 0x4 read failed (-121)
>>> [   29.453930] lm90 0-004c: Failed to read convrate register!
>>> [   29.460034] lm90 0-004c: Register 0x3 read failed (-121)
>>> [   29.465408] lm90 0-004c: Initialization failed!
>>>
>>> So, there's something wrong here, and I've dropped the patch for
>>> Dalmore. Does this patch actually work for you?
>>>
>> I test it with the Chrome u-boot, the lm90 works fine.
>> But today, if I tried to use the uboot from
>> git://git.denx.de/u-boot-tegra.git, I can repo your errors, it seems the
>> i2c can't work, the lm90 driver read register failed.
>> I traced it, but can't find the root cause yet.
> 
> Hi, Stephen
> I found the root cause.
> In the Chrome u-boot, it will turn on the regulator for the lm90, but in
> the upstream u-boot, it didn't do it.

> I think this regulator should be handled in the kernel driver, but it
> seems the regulator palmas tps65913 didn't be supported on the dalmore yet.
> So may be we have to wait the palmas ready on dalmore.

Yes, I agree. (although Laxman's regulator patch caused the SD card to
stop working, so that needs to be fixed up, but hopefully it's a simple
issue).