From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755276Ab3GQNBb (ORCPT ); Wed, 17 Jul 2013 09:01:31 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:47083 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755160Ab3GQNB1 (ORCPT ); Wed, 17 Jul 2013 09:01:27 -0400 Message-ID: <51E69429.7040309@linux.vnet.ibm.com> Date: Wed, 17 Jul 2013 18:25:05 +0530 From: Raghavendra K T Organization: IBM User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: Gleb Natapov CC: mingo@redhat.com, jeremy@goop.org, x86@kernel.org, konrad.wilk@oracle.com, hpa@zytor.com, pbonzini@redhat.com, linux-doc@vger.kernel.org, habanero@linux.vnet.ibm.com, xen-devel@lists.xensource.com, peterz@infradead.org, mtosatti@redhat.com, stefano.stabellini@eu.citrix.com, andi@firstfloor.org, ouyang@cs.pitt.edu, agraf@suse.de, chegu_vinod@hp.com, torvalds@linux-foundation.org, avi.kivity@gmail.com, tglx@linutronix.de, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, riel@redhat.com, drjones@redhat.com, virtualization@lists.linux-foundation.org, srivatsa.vaddagiri@gmail.com Subject: Re: [PATCH RFC V10 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor References: <20130624124014.27508.8906.sendpatchset@codeblue.in.ibm.com> <20130624124342.27508.44656.sendpatchset@codeblue.in.ibm.com> <20130714131241.GA11772@redhat.com> <51E3C5CE.7000009@linux.vnet.ibm.com> <20130715103648.GN11772@redhat.com> <51E4C011.4060803@linux.vnet.ibm.com> <20130716060215.GE11772@redhat.com> <51E5941B.3090300@linux.vnet.ibm.com> <20130717093420.GU11772@redhat.com> <51E66C71.6020605@linux.vnet.ibm.com> <20130717124511.GW11772@redhat.com> In-Reply-To: <20130717124511.GW11772@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13071712-5490-0000-0000-000003D65E47 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/17/2013 06:15 PM, Gleb Natapov wrote: > On Wed, Jul 17, 2013 at 03:35:37PM +0530, Raghavendra K T wrote: >>>> Instead of halt we started with a sleep hypercall in those >>>> versions. Changed to halt() once Avi suggested to reuse existing sleep. >>>> >>>> If we use older hypercall with few changes like below: >>>> >>>> kvm_pv_wait_for_kick_op(flags, vcpu, w->lock ) >>>> { >>>> // a0 reserved for flags >>>> if (!w->lock) >>>> return; >>>> DEFINE_WAIT >>>> ... >>>> end_wait >>>> } >>>> >>> How would this help if NMI takes lock in critical section. The thing >>> that may happen is that lock_waiting->want may have NMI lock value, but >>> lock_waiting->lock will point to non NMI lock. Setting of want and lock >>> have to be atomic. >> >> True. so we are here >> >> non NMI lock(a) >> w->lock = NULL; >> smp_wmb(); >> w->want = want; >> NMI >> <--------------------- >> NMI lock(b) >> w->lock = NULL; >> smp_wmb(); >> w->want = want; >> smp_wmb(); >> w->lock = lock; >> ----------------------> >> smp_wmb(); >> w->lock = lock; >> >> so how about fixing like this? >> >> again: >> w->lock = NULL; >> smp_wmb(); >> w->want = want; >> smp_wmb(); >> w->lock = lock; >> >> if (!lock || w->want != want) goto again; >> > NMI can happen after the if() but before halt and the same situation > we are trying to prevent with IRQs will occur. True, we can not fix that. I thought to fix the inconsistency of lock,want pair. But NMI could happen after the first OR condition also. /me thinks again But if NMI handler do not > take locks we shouldn't worry. Okay. Thanks for the reviews. 'll spin the next version with all the suggested changes.