From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755288Ab3GQNEa (ORCPT ); Wed, 17 Jul 2013 09:04:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7222 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754860Ab3GQNE3 (ORCPT ); Wed, 17 Jul 2013 09:04:29 -0400 Message-ID: <51E69648.8050007@redhat.com> Date: Wed, 17 Jul 2013 09:04:08 -0400 From: Don Dutile User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12 MIME-Version: 1.0 To: Neil Horman CC: linux-kernel@vger.kernel.org, Jan Beulich , Joerg Roedel , Andrew Cooper , Malcolm Crossley , Prarit Bhargava , Don Zickus , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] iommu/vt-d: Expand interrupt remapping quirk to cover x58 chipset References: <1373397069-8968-1-git-send-email-nhorman@tuxdriver.com> <1374059639-8631-1-git-send-email-nhorman@tuxdriver.com> In-Reply-To: <1374059639-8631-1-git-send-email-nhorman@tuxdriver.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/17/2013 07:13 AM, Neil Horman wrote: > Recently we added an early quirk to detect 5500/5520 chipsets with early > revisions that had problems with irq draining with interrupt remapping enabled: > > commit 03bbcb2e7e292838bb0244f5a7816d194c911d62 > Author: Neil Horman > Date: Tue Apr 16 16:38:32 2013 -0400 > > iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets > > It turns out this same problem is present in the intel X58 chipset as well. See > errata 69 here: > http://www.intel.com/content/www/us/en/chipsets/x58-express-specification-update.html > > This patch extends the pci early quirk so that the chip devices/revisions > specified in the above update are also covered in the same way: > > Signed-off-by: Neil Horman > Reviewed-by: Jan Beulich > CC: Jan Beulich > CC: Joerg Roedel > CC: Andrew Cooper > CC: Malcolm Crossley > CC: Prarit Bhargava > CC: Don Zickus > CC: Don Dutile > CC: Thomas Gleixner > CC: Ingo Molnar > CC: "H. Peter Anvin" > CC: x86@kernel.org > CC: stable@vger.kernel.org > > --- > Note, this a repost of this patch. Don and I talked about this offline again, > and neither of us have been able to gather any information from intel on the > subject. While I understand his point that we should try to get confirmation > about inclusive steppings that are affected by this errata, I feel like we > should commit this patch based on the documentation we do have, and we can > always ammend it later if Intel indicates other chips are affected. and to back-up what Neil says... Acked-by: Donald Dutile > --- > arch/x86/kernel/early-quirks.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c > index 94ab6b9..743d583 100644 > --- a/arch/x86/kernel/early-quirks.c > +++ b/arch/x86/kernel/early-quirks.c > @@ -196,15 +196,23 @@ static void __init ati_bugs_contd(int num, int slot, int func) > static void __init intel_remapping_check(int num, int slot, int func) > { > u8 revision; > + u16 device; > > + device = read_pci_config_16(num, slot, func, PCI_DEVICE_ID); > revision = read_pci_config_byte(num, slot, func, PCI_REVISION_ID); > > /* > - * Revision 0x13 of this chipset supports irq remapping > - * but has an erratum that breaks its behavior, flag it as such > + * Revision 13 of all triggering devices id in this quirk have > + * a problem draining interrupts when irq remapping is enabled, > + * and should be flagged as broken. Additionally revisions 0x12 > + * and 0x22 of device id 0x3405 has this problem. > */ > if (revision == 0x13) > set_irq_remapping_broken(); > + else if ((device == 0x3405)&& > + ((revision == 0x12) || > + (revision == 0x22))) > + set_irq_remapping_broken(); > > } > > @@ -239,8 +247,11 @@ static struct chipset early_qrk[] __initdata = { > PCI_CLASS_SERIAL_SMBUS, PCI_ANY_ID, 0, ati_bugs_contd }, > { PCI_VENDOR_ID_INTEL, 0x3403, PCI_CLASS_BRIDGE_HOST, > PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check }, > + { PCI_VENDOR_ID_INTEL, 0x3405, PCI_CLASS_BRIDGE_HOST, > + PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check }, > { PCI_VENDOR_ID_INTEL, 0x3406, PCI_CLASS_BRIDGE_HOST, > PCI_BASE_CLASS_BRIDGE, 0, intel_remapping_check }, > + > {} > }; >