From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759071Ab3GRN5v (ORCPT ); Thu, 18 Jul 2013 09:57:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62179 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758433Ab3GRN5t (ORCPT ); Thu, 18 Jul 2013 09:57:49 -0400 Message-ID: <51E7F440.2010600@redhat.com> Date: Thu, 18 Jul 2013 15:57:20 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Christian Borntraeger CC: Gleb Natapov , Dominik Dingel , Heiko Carstens , Martin Schwidefsky , Cornelia Huck , Xiantao Zhang , Alexander Graf , Christoffer Dall , Marc Zyngier , Ralf Baechle , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] PF: Async page fault support on s390 References: <1373461195-27628-1-git-send-email-dingel@linux.vnet.ibm.com> <1373461195-27628-5-git-send-email-dingel@linux.vnet.ibm.com> <20130711090411.GA8575@redhat.com> <51DE8BE1.8000902@de.ibm.com> In-Reply-To: <51DE8BE1.8000902@de.ibm.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 11/07/2013 12:41, Christian Borntraeger ha scritto: > On 11/07/13 11:04, Gleb Natapov wrote: >> On Wed, Jul 10, 2013 at 02:59:55PM +0200, Dominik Dingel wrote: >>> This patch enables async page faults for s390 kvm guests. >>> It provides the userspace API to enable, disable or get the status of this >>> feature. Also it includes the diagnose code, called by the guest to enable >>> async page faults. >>> >>> The async page faults will use an already existing guest interface for this >>> purpose, as described in "CP Programming Services (SC24-6084)". >>> >>> Signed-off-by: Dominik Dingel >> Christian, looks good now? > > Looks good, but I just had a discussion with Dominik about several other cases > (guest driven reboot, qemu driven reboot, life migration). This patch should > allow all these cases (independent from this patch we need an ioctl to flush the > list of pending interrupts to do so, but reboot is currently broken in that > regard anyway - patch is currently being looked at) > > We are currently discussion if we should get rid of the APF_STATUS and let > the kernel wait for outstanding page faults before returning from KVM_RUN > or if we go with this patch and let userspace wait for completion. > > Will discuss this with Dominik, Conny and Alex. So lets defer that till next > week, ok? Let us know if we should wait for a v5. :) Paolo