public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Feng Tang <feng.tang@intel.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: perf: support for named threads broken
Date: Thu, 18 Jul 2013 14:50:36 -0600	[thread overview]
Message-ID: <51E8551C.5040708@gmail.com> (raw)

Hi Feng:

I noticed today that support for named threads is busted in latest perf. 
git bisect shows the first bad commit as:

commit 73994dc158a24df4af77d0a76c9702f120f7a6ad
Author: Feng Tang <feng.tang@intel.com>
Date:   Wed Aug 8 17:57:52 2012 +0800

     perf script: Replace "struct thread" with "struct addr_location" as 
a parameter for "process_event()"

     Both perl and python script start processing events other than trace
     points, and it's useful to pass the resolved symbol and the dso info to
     the event handler in script for better analysis and statistics.

     Struct thread is already a member of struct addr_location, using
     addr_location will keep the thread info, while providing additional
     symbol and dso info if exist, so that the script itself doesn't need to
     bother to do the symbol resolving and dso searching work.


I conveniently cut-off the Tested-by and Acked-by from me ;-)
Clearly I did not test named threads.

Can you take a look?

David

                 reply	other threads:[~2013-07-18 20:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E8551C.5040708@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=feng.tang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox