From: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] tracing: use trace_seq_puts()/trace_seq_putc() where possible
Date: Fri, 19 Jul 2013 09:40:11 +0800 [thread overview]
Message-ID: <51E898FB.2000006@huawei.com> (raw)
In-Reply-To: <1374197370.3356.8.camel@gandalf.local.home>
On 2013/7/19 9:29, Steven Rostedt wrote:
> On Mon, 2013-07-15 at 16:32 +0800, zhangwei(Jovi) wrote:
>> diff --git a/kernel/trace/trace_functions_graph.c
>> b/kernel/trace/trace_functions_graph.c
>> index 8388bc9..3793f90 100644
>> --- a/kernel/trace/trace_functions_graph.c
>> +++ b/kernel/trace/trace_functions_graph.c
>> @@ -446,7 +446,7 @@ print_graph_proc(struct trace_seq *s, pid_t pid)
>>
>> /* First spaces to align center */
>> for (i = 0; i < spaces / 2; i++) {
>> - ret = trace_seq_printf(s, " ");
>> + ret = trace_seq_putc(s, ' ');
>> if (!ret)
>> return TRACE_TYPE_PARTIAL_LINE;
>> }
>> @@ -457,7 +457,7 @@ print_graph_proc(struct trace_seq *s, pid_t pid)
>>
>> /* Last spaces to align center */
>> for (i = 0; i < spaces - (spaces / 2); i++) {
>> - ret = trace_seq_printf(s, " ");
>> + ret = trace_seq_putc(s, " ");
>
> Oops, s/"/'/g
>
> I'll fix it.
>
Sorry for this, I will open my eyes more larger next time.
jovi
next prev parent reply other threads:[~2013-07-19 1:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 8:32 [PATCH 2/3] tracing: use trace_seq_puts()/trace_seq_putc() where possible zhangwei(Jovi)
2013-07-19 1:29 ` Steven Rostedt
2013-07-19 1:40 ` zhangwei(Jovi) [this message]
2013-07-19 1:51 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E898FB.2000006@huawei.com \
--to=jovi.zhangwei@huawei.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox