Re: [PATCH] crypto: remove double execution of the same test suite

Horia Geantă
2013-07-19T06:49:08Z

On 7/18/2013 6:57 PM, Cristian Stoica wrote:
> This patch removes redundant execution of the same test suite in cases
> where alg and driver variables are the same (e.g. when alg_test is
> called from tcrypt_test)
>
> Signed-off-by: Cristian Stoica <cristian.stoica@freescale.com>

Reviewed-by: Horia Geanta <horia.geanta@freescale.com>

> ---
> crypto/testmgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index 2f00607..e091ef6 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -3234,7 +3234,7 @@ int alg_test(const char *driver, const char *alg, u32 type, u32 mask)
> if (i >= 0)
> rc |= alg_test_descs[i].test(alg_test_descs + i, driver,
> type, mask);
> - if (j >= 0)
> + if (j >= 0 && j != i)
> rc |= alg_test_descs[j].test(alg_test_descs + j, driver,
> type, mask);
>
>