From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Hector Palacios <hector.palacios@digi.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, marex@denx.de,
jic23@kernel.org, lars@metafoo.de, fabio.estevam@freescale.com
Subject: Re: [PATCH v2 4/5] iio: mxs-lradc: add scale_available file to channels
Date: Fri, 19 Jul 2013 19:20:55 +0200 [thread overview]
Message-ID: <51E97577.80801@free-electrons.com> (raw)
In-Reply-To: <1374225208-28940-5-git-send-email-hector.palacios@digi.com>
On 19/07/2013 11:13, Hector Palacios wrote:
> Adds in_voltageX_scale_available file for every channel to read
> the different available scales.
> There are two scales per channel:
> [0] = divider_by_two disabled (default)
> [1] = divider_by_two enabled
>
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
Looks good to me:
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
And you are right, we will probably need to hide the 64bits math. I'll
try to think of something.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-07-19 17:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 9:13 [PATCH v2 0/5] iio: mxs-lradc: add support to optional divider_by_two Hector Palacios
2013-07-19 9:13 ` [PATCH v2 1/5] iio: mxs-lradc: change the realbits to 12 Hector Palacios
2013-07-19 13:56 ` Marek Vasut
2013-07-19 17:09 ` Alexandre Belloni
2013-07-19 9:13 ` [PATCH v2 2/5] ARM: dts: add reference voltage property for MXS LRADC Hector Palacios
2013-07-19 13:58 ` Marek Vasut
2013-07-19 17:10 ` Alexandre Belloni
2013-07-19 9:13 ` [PATCH v2 3/5] iio: mxs-lradc: add scale attribute to channels Hector Palacios
2013-07-19 14:30 ` Marek Vasut
2013-07-19 15:44 ` Hector Palacios
2013-07-19 16:14 ` Marek Vasut
2013-07-22 7:22 ` Hector Palacios
2013-07-22 7:42 ` Marek Vasut
2013-07-22 7:46 ` Hector Palacios
2013-07-22 7:58 ` Marek Vasut
2013-07-19 17:06 ` Alexandre Belloni
2013-07-22 7:26 ` Hector Palacios
2013-07-19 9:13 ` [PATCH v2 4/5] iio: mxs-lradc: add scale_available file " Hector Palacios
2013-07-19 17:20 ` Alexandre Belloni [this message]
2013-07-19 9:13 ` [PATCH v2 5/5] iio: mxs-lradc: add write_raw function to modify scale Hector Palacios
2013-07-19 14:39 ` Marek Vasut
2013-07-19 15:31 ` Hector Palacios
2013-07-19 16:17 ` Marek Vasut
2013-07-19 16:22 ` Hector Palacios
2013-07-19 20:23 ` Jonathan Cameron
2013-07-20 19:00 ` Marek Vasut
2013-07-19 20:32 ` Jonathan Cameron
2013-07-22 8:01 ` Hector Palacios
2013-07-19 17:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E97577.80801@free-electrons.com \
--to=alexandre.belloni@free-electrons.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.estevam@freescale.com \
--cc=hector.palacios@digi.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox