From: Casey Schaufler <casey@schaufler-ca.com>
To: Phil Carmody <phil.carmody@partner.samsung.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, jarkko.sakkinen@iki.fi,
Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH] smack: fix magic value
Date: Sat, 20 Jul 2013 18:41:35 -0700 [thread overview]
Message-ID: <51EB3C4F.8070805@schaufler-ca.com> (raw)
In-Reply-To: <1373457073-2571-1-git-send-email-phil.carmody@partner.samsung.com>
On 7/10/2013 4:51 AM, Phil Carmody wrote:
> 5d is ']', 'M' is 4d.
And spelling was never my strong suit. I don't know of anyone
who depends on this value, but in case someone does the correct
fix is to change the comment, not the constant.
>
> Signed-off-by: Phil Carmody <phil.carmody@partner.samsung.com>
> ---
> include/uapi/linux/magic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h
> index 2944278..5c1d878 100644
> --- a/include/uapi/linux/magic.h
> +++ b/include/uapi/linux/magic.h
> @@ -11,7 +11,7 @@
> #define DEBUGFS_MAGIC 0x64626720
> #define SECURITYFS_MAGIC 0x73636673
> #define SELINUX_MAGIC 0xf97cff8c
> -#define SMACK_MAGIC 0x43415d53 /* "SMAC" */
> +#define SMACK_MAGIC 0x43414d53 /* "SMAC" */
> #define RAMFS_MAGIC 0x858458f6 /* some random number */
> #define TMPFS_MAGIC 0x01021994
> #define HUGETLBFS_MAGIC 0x958458f6 /* some random number */
prev parent reply other threads:[~2013-07-21 1:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 11:51 [PATCH] smack: fix magic value Phil Carmody
2013-07-21 1:41 ` Casey Schaufler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EB3C4F.8070805@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=jarkko.sakkinen@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=phil.carmody@partner.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox