Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

[George Cherian <george.cherian@ti.com>]

On 7/20/2013 9:11 AM, George Cherian wrote:
> On 7/20/2013 12:12 AM, Sebastian Andrzej Siewior wrote:
>> On 07/19/2013 08:33 PM, Sergei Shtylyov wrote:
>>> Hello.
>> Hello,
>>
>>>> usb: usb@47400000 {
>>>>      compatible = "ti,am33xx-usb";
>>>>           usb0_phy: phy@47401300 {
>>>>          compatible = "ti,am335x-usb-phy";
>>>>      }
>>>>      usb0: usb@47401000 {
>>>>          musb0: usb@47401400 {
>>>>              compatible = "mg,musbmhdrc";
>>>>          }
>>>>      }
>>>>      usb1_phy: phy@47402300 {
>>>>          compatible = "ti,am335x-usb-phy";
>>>>      }
>>>>      usb1: usb@47402000 {
>>>>          musb1: usb@47402400 {
>>>>              compatible = "mg,musbmhdrc";
>>>>          }
>>>>      }
>>>> }

How about something like this ?

Here am making
     wrapper -> musb instance 0 -> phy0
     wrapper -> musb instance 1 -> phy1

                 musb: usb@47400000 {
                         compatible = "ti,musb-am33xx";
                         reg = <0x47400000 0x1000>;
                         ranges;
                         #address-cells = <1>;
                         #size-cells = <1>;
                         interrupts = <17>;
                         ti,hwmods = "usb_otg_hs";

                         usb0@47401000 {
                                 reg = <0x47401000 0x800>;
                                 interrupts = <18>;
                                 interrupt-names = "mc";
                                 multipoint = <1>;
                                 num-eps = <16>;
                                 ram-bits = <12>;
                                 port-mode = <3>;
                                 power = <250>;
                                 phys = <&phy1>;
                                 phy-names = "am335x-usb0";
                                 phy1: am335x-usb0 {
                                         compatible = "ti,am335x-usb2";
                                         #phy-cells = <0>;
                                         id= <0>;
                                 };
                         };

                         usb1@47401800 {
                                 reg = <0x47401800 0x800>;
                                 interrupts = <19>;
                                 interrupt-names = "mc";
                                 multipoint = <1>;
                                 num-eps = <16>;
                                 ram-bits = <12>;
                                 port-mode = <3>;
                                 power = <250>;
                                 phys = <&phy2>;
                                 phy-names = "am335x-usb1";
                                 phy2: am335x-usb1 {
                                         compatible = "ti,am335x-usb2";
                                         #phy-cells = <0>;
                                         id= <1>;
                                 };
                         };

                 };

-- 
-George