* [PATCH v2] x86, acpi: Correct out-of-date comment of __acpi_map_table
@ 2013-07-23 13:03 Zhang Yanfei
2013-07-27 9:58 ` [tip:x86/platform] x86/acpi: Correct out-of-date comment of __acpi_map_table() tip-bot for Zhang Yanfei
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Yanfei @ 2013-07-23 13:03 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, len.brown, pavel,
rjw
Cc: linux-kernel@vger.kernel.org
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
The implementation of function __acpi_map_table() has been changed
long time ago, and now it directly invokes early_ioremap() to setup
the temporarily acpi table mappings. So correct its out-of-date
comment.
Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
-v2: Replace the comment with a simple correct one instead of removing
it -- suggested by Ingo
---
arch/x86/kernel/acpi/boot.c | 13 +++----------
1 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 2627a81..c7f61cf 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -141,16 +141,8 @@ static u32 irq_to_gsi(int irq)
}
/*
- * Temporarily use the virtual area starting from FIX_IO_APIC_BASE_END,
- * to map the target physical address. The problem is that set_fixmap()
- * provides a single page, and it is possible that the page is not
- * sufficient.
- * By using this area, we can map up to MAX_IO_APICS pages temporarily,
- * i.e. until the next __va_range() call.
- *
- * Important Safety Note: The fixed I/O APIC page numbers are *subtracted*
- * from the fixed base. That's why we start at FIX_IO_APIC_BASE_END and
- * count idx down while incrementing the phys address.
+ * This is just a simple wrapper around early_ioremap(),
+ * with sanity checks for phys == 0 and size == 0.
*/
char *__init __acpi_map_table(unsigned long phys, unsigned long size)
{
@@ -160,6 +152,7 @@ char *__init __acpi_map_table(unsigned long phys, unsigned long size)
return early_ioremap(phys, size);
}
+
void __init __acpi_unmap_table(char *map, unsigned long size)
{
if (!map || !size)
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/platform] x86/acpi: Correct out-of-date comment of __acpi_map_table()
2013-07-23 13:03 [PATCH v2] x86, acpi: Correct out-of-date comment of __acpi_map_table Zhang Yanfei
@ 2013-07-27 9:58 ` tip-bot for Zhang Yanfei
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Zhang Yanfei @ 2013-07-27 9:58 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, zhangyanfei, tglx
Commit-ID: 45f1330af6819b348fbac89e69d59d8129d61960
Gitweb: http://git.kernel.org/tip/45f1330af6819b348fbac89e69d59d8129d61960
Author: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
AuthorDate: Tue, 23 Jul 2013 21:03:24 +0800
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 26 Jul 2013 22:12:36 +0200
x86/acpi: Correct out-of-date comment of __acpi_map_table()
The implementation of function __acpi_map_table() has been
changed long time ago, and now it directly invokes
early_ioremap() to setup the temporarily acpi table mappings.
So correct its out-of-date comment.
Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: len.brown@intel.com
Cc: pavel@ucw.cz
Cc: rjw@sisk.pl
Link: http://lkml.kernel.org/r/51EE7F1C.9020506@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/acpi/boot.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 2627a81..c7f61cf 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -141,16 +141,8 @@ static u32 irq_to_gsi(int irq)
}
/*
- * Temporarily use the virtual area starting from FIX_IO_APIC_BASE_END,
- * to map the target physical address. The problem is that set_fixmap()
- * provides a single page, and it is possible that the page is not
- * sufficient.
- * By using this area, we can map up to MAX_IO_APICS pages temporarily,
- * i.e. until the next __va_range() call.
- *
- * Important Safety Note: The fixed I/O APIC page numbers are *subtracted*
- * from the fixed base. That's why we start at FIX_IO_APIC_BASE_END and
- * count idx down while incrementing the phys address.
+ * This is just a simple wrapper around early_ioremap(),
+ * with sanity checks for phys == 0 and size == 0.
*/
char *__init __acpi_map_table(unsigned long phys, unsigned long size)
{
@@ -160,6 +152,7 @@ char *__init __acpi_map_table(unsigned long phys, unsigned long size)
return early_ioremap(phys, size);
}
+
void __init __acpi_unmap_table(char *map, unsigned long size)
{
if (!map || !size)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-27 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-23 13:03 [PATCH v2] x86, acpi: Correct out-of-date comment of __acpi_map_table Zhang Yanfei
2013-07-27 9:58 ` [tip:x86/platform] x86/acpi: Correct out-of-date comment of __acpi_map_table() tip-bot for Zhang Yanfei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox