From: Chen Gang <gang.chen@asianux.com>
To: sameo@linux.intel.com, lee.jones@linaro.org
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled.
Date: Wed, 24 Jul 2013 11:33:04 +0800 [thread overview]
Message-ID: <51EF4AF0.1000509@asianux.com> (raw)
In-Reply-To: <51EF1763.3020904@asianux.com>
'irq_domain' depends on hard irqs, so for the architectures which have
no hard irqs, but still need mfd (e.g. s390), need disable the related
code, or can not pass compiling.
The related commit:
"c94bb23 mfd: Make MFD core code Device Tree and IRQ domain aware"
The related error: (with allmodconfig under s390)
ERROR: "irq_create_mapping" [drivers/mfd/mfd-core.ko] undefined!
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/mfd/mfd-core.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 7604f4e..8e56a74 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -129,13 +129,16 @@ static int mfd_add_device(struct device *parent, int id,
res[r].end = mem_base->start +
cell->resources[r].end;
} else if (cell->resources[r].flags & IORESOURCE_IRQ) {
+#ifdef HAVE_GENERIC_HARDIRQS
if (domain) {
/* Unable to create mappings for IRQ ranges. */
WARN_ON(cell->resources[r].start !=
cell->resources[r].end);
res[r].start = res[r].end = irq_create_mapping(
domain, cell->resources[r].start);
- } else {
+ } else
+#endif
+ {
res[r].start = irq_base +
cell->resources[r].start;
res[r].end = irq_base +
--
1.7.7.6
next parent reply other threads:[~2013-07-24 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51EE3E20.1090101@asianux.com>
[not found] ` <20130723104703.GB26775@osiris>
[not found] ` <51EF1763.3020904@asianux.com>
2013-07-24 3:33 ` Chen Gang [this message]
2013-07-24 5:02 ` [PATCH] drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled Heiko Carstens
2013-07-24 5:31 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EF4AF0.1000509@asianux.com \
--to=gang.chen@asianux.com \
--cc=heiko.carstens@de.ibm.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox