* [PATCH] drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled.
[not found] ` <51EF1763.3020904@asianux.com>
@ 2013-07-24 3:33 ` Chen Gang
2013-07-24 5:02 ` Heiko Carstens
0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2013-07-24 3:33 UTC (permalink / raw)
To: sameo, lee.jones
Cc: Heiko Carstens, Martin Schwidefsky, linux-kernel@vger.kernel.org
'irq_domain' depends on hard irqs, so for the architectures which have
no hard irqs, but still need mfd (e.g. s390), need disable the related
code, or can not pass compiling.
The related commit:
"c94bb23 mfd: Make MFD core code Device Tree and IRQ domain aware"
The related error: (with allmodconfig under s390)
ERROR: "irq_create_mapping" [drivers/mfd/mfd-core.ko] undefined!
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/mfd/mfd-core.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 7604f4e..8e56a74 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -129,13 +129,16 @@ static int mfd_add_device(struct device *parent, int id,
res[r].end = mem_base->start +
cell->resources[r].end;
} else if (cell->resources[r].flags & IORESOURCE_IRQ) {
+#ifdef HAVE_GENERIC_HARDIRQS
if (domain) {
/* Unable to create mappings for IRQ ranges. */
WARN_ON(cell->resources[r].start !=
cell->resources[r].end);
res[r].start = res[r].end = irq_create_mapping(
domain, cell->resources[r].start);
- } else {
+ } else
+#endif
+ {
res[r].start = irq_base +
cell->resources[r].start;
res[r].end = irq_base +
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled.
2013-07-24 3:33 ` [PATCH] drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled Chen Gang
@ 2013-07-24 5:02 ` Heiko Carstens
2013-07-24 5:31 ` Chen Gang
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2013-07-24 5:02 UTC (permalink / raw)
To: Chen Gang
Cc: sameo, lee.jones, Martin Schwidefsky,
linux-kernel@vger.kernel.org
On Wed, Jul 24, 2013 at 11:33:04AM +0800, Chen Gang wrote:
> 'irq_domain' depends on hard irqs, so for the architectures which have
> no hard irqs, but still need mfd (e.g. s390), need disable the related
> code, or can not pass compiling.
>
> The related commit:
>
> "c94bb23 mfd: Make MFD core code Device Tree and IRQ domain aware"
>
> The related error: (with allmodconfig under s390)
>
> ERROR: "irq_create_mapping" [drivers/mfd/mfd-core.ko] undefined!
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
s390 will have GENERIC_HARDIRQS soon (very likely next merge window),
so lets not add more GENERIC_HARDIRQS ifdefs in the code.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled.
2013-07-24 5:02 ` Heiko Carstens
@ 2013-07-24 5:31 ` Chen Gang
0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2013-07-24 5:31 UTC (permalink / raw)
To: Heiko Carstens
Cc: sameo, lee.jones, Martin Schwidefsky,
linux-kernel@vger.kernel.org
On 07/24/2013 01:02 PM, Heiko Carstens wrote:
> On Wed, Jul 24, 2013 at 11:33:04AM +0800, Chen Gang wrote:
>> > 'irq_domain' depends on hard irqs, so for the architectures which have
>> > no hard irqs, but still need mfd (e.g. s390), need disable the related
>> > code, or can not pass compiling.
>> >
>> > The related commit:
>> >
>> > "c94bb23 mfd: Make MFD core code Device Tree and IRQ domain aware"
>> >
>> > The related error: (with allmodconfig under s390)
>> >
>> > ERROR: "irq_create_mapping" [drivers/mfd/mfd-core.ko] undefined!
>> >
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> s390 will have GENERIC_HARDIRQS soon (very likely next merge window),
> so lets not add more GENERIC_HARDIRQS ifdefs in the code.
>
OK, thanks.
--
Chen Gang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-24 5:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <51EE3E20.1090101@asianux.com>
[not found] ` <20130723104703.GB26775@osiris>
[not found] ` <51EF1763.3020904@asianux.com>
2013-07-24 3:33 ` [PATCH] drivers: mfd: mfd-core: disable irq_domain related code when 'HAVE_GENERIC_HARDIRQS' disabled Chen Gang
2013-07-24 5:02 ` Heiko Carstens
2013-07-24 5:31 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox