From: "\"Jóhann B. Guðmundsson\"" <johannbg@gmail.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "Theodore Tso" <tytso@mit.edu>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
"\"Jóhann B. Guðmundsson\"" <johannbg@fedoraproject.org>
Subject: Re: [PATCH 1/1] ext4: Fix Opts: (null)
Date: Wed, 24 Jul 2013 09:02:04 +0000 [thread overview]
Message-ID: <51EF980C.5010203@gmail.com> (raw)
In-Reply-To: <51EF3990.4010901@redhat.com>
On 07/24/2013 02:18 AM, Eric Sandeen wrote:
> Have you tested it? What's the difference in output?
- ext4_msg(sb, KERN_INFO, "mounted filesystem with%s. "
- "Opts: %s%s%s", descr, sbi->s_es->s_mount_opts,
+ ext4_msg(sb, KERN_INFO, "mounted filesystem with%s "
+ "%s%s%s mount option(s)", descr, sbi->s_es->s_mount_opts,
*sbi->s_es->s_mount_opts ? "; " : "", orig_data);
From
mounted filesystem with Opts: (null)
re-mounted. Opts:(null)
To
mounted filesystem with (null) mount option(s)
re-mounted (null) mount option(s)
That (null) could change to no or none I suppose but it still feels a bit off thou maybe this output sample would be better?
if = (null)
mounted filesystem
re-mounted filesystem
elif
mounted filesystem with x,y.x mount option(s)
re-mounted filesystem with x,y.x mount option(s)
JBG
prev parent reply other threads:[~2013-07-24 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 22:24 [PATCH 1/1] ext4: Fix Opts: (null) Jóhann B. Guðmundsson
2013-07-24 2:18 ` Eric Sandeen
2013-07-24 9:02 ` "Jóhann B. Guðmundsson" [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EF980C.5010203@gmail.com \
--to=johannbg@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=johannbg@fedoraproject.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox